chore: drop ghost phpunit and phpunit-coverage docker services#42
Merged
Conversation
These compose services referenced dockerfile: Dockerfile.test which has never existed in the repo — and the corresponding Taskfile entries (task test:docker, task test:coverage) have been broken since they were added. The functionality is covered elsewhere: - task test:unit runs unit tests locally (composer test:unit) - task test:integration / task test:e2e exec into the running openemr container (matches the pattern that already works) - CI handles coverage via the openCoreEMR/github-workflows-public php-tests reusable when opted in via coverage-php-version If local coverage HTML reports become a real need, add a Dockerfile.test and reintroduce the services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two compose services (
phpunit,phpunit-coverage) and two Taskfile entries (task test:docker,task test:coverage) that have been broken since they were added — they referencedockerfile: Dockerfile.test, but that file has never existed in the repo. Hidden until now because the services live underprofiles: [test]and only run on explicit invocation.Spotted while reviewing #41.
Why drop instead of fix
The functionality is covered elsewhere:
task test:unitruns unit tests locally (composer test:unit)task test:integration/task test:e2eexec into the runningopenemrcontainer (matches the existing pattern that already works)openCoreEMR/github-workflows-public/php-tests.ymlreusable when opted in viacoverage-php-versionIf local coverage HTML reports become a real need, add
Dockerfile.testand reintroduce the services.Test plan
task --listno longer showstest:docker/test:coveragedocker compose configstill validates