fix(commands): render full stack trace when verbose#34
Merged
Conversation
AbstractUserCommand::execute caught Throwable and printed only getMessage(), so operators got a one-line summary even with -v. Honor verbosity by additionally rendering the throwable with file, line, and trace via Application::renderThrowable. Closes #11 Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractUserCommand::executecaught\Throwableand printed onlygetMessage(), so operators got a one-line summary even when running with-v. Honor verbosity by additionally rendering the throwable (file, line, full trace) viaApplication::renderThrowable.Closes #11
Test plan
user:*command in a way that throws (e.g. invalid--openemr-path) without-v— only the one-line error appears.-v— full stack trace is rendered after the error message.