Fix OpenVPN client: stack corruption, memory leak, key zeroing, dangling netif#128
Draft
Fix OpenVPN client: stack corruption, memory leak, key zeroing, dangling netif#128
Conversation
…ing netif, spurious event, dead code Co-authored-by: wendal <589819+wendal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review openvpn client implementation and suggest improvements
Fix OpenVPN client: stack corruption, memory leak, key zeroing, dangling netif
Mar 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Code review of the OpenVPN client implementation surfaced several bugs across the binding, adapter, and core layers.
Fixes
luat_lib_netdrv.c): Extralua_pop(L, 1)pops the config table beforeluat_netdrv_setup()consumes it — removedluat_netdrv_openvpn.c): TLS contexts and cert buffers fromovpn_client_init()leaked whenluat_netdrv_register()failed — addedovpn_client_stop()before freeluat_netdrv_openvpn_client.c):client_key_buffreed without zeroing — now usesmbedtls_platform_zeroize()to prevent key material lingering in heapluat_netdrv_openvpn_client.c):net_lwip2_set_netif()not cleared on stop, leaving stale pointer in lwIP adapter table — addednet_lwip2_set_netif(adapter_index, NULL)OVPN_EVENT_DISCONNECTEDfired even when client was never started — now gated onwas_startedopenvpn_shutdown()(defined but never wired to any netdrv callback)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.