fix: treat empty OPENAI_BASE_URL as unset#2928
Open
LuciferDono wants to merge 1 commit intoopenai:mainfrom
Open
fix: treat empty OPENAI_BASE_URL as unset#2928LuciferDono wants to merge 1 commit intoopenai:mainfrom
LuciferDono wants to merge 1 commit intoopenai:mainfrom
Conversation
When OPENAI_BASE_URL is defined but empty, os.environ.get() returns "" instead of None, so the fallback to https://api.openai.com/v1 is skipped. Add `or None` to coerce empty strings to None in both the sync and async client constructors. Fixes openai#2927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
OPENAI_BASE_URLis set to an empty string (e.g.export OPENAI_BASE_URL=""),os.environ.get("OPENAI_BASE_URL")returns""instead ofNone. The subsequentif base_url is Nonecheck passes, so the defaulthttps://api.openai.com/v1fallback is never applied. This causes anAPIConnectionErroron the next API call.Fixes #2927.
Change
Added
or Noneto coerce empty strings toNonein both theOpenAIandAsyncOpenAIconstructors:This is consistent with how an unset variable should behave — an empty string is not a valid base URL.