fix(openapi-fetch): pass string bodies through without JSON serialization#2761
Open
Nedunchezhiyan-M wants to merge 2 commits intoopenapi-ts:mainfrom
Open
fix(openapi-fetch): pass string bodies through without JSON serialization#2761Nedunchezhiyan-M wants to merge 2 commits intoopenapi-ts:mainfrom
Nedunchezhiyan-M wants to merge 2 commits intoopenapi-ts:mainfrom
Conversation
…tion defaultBodySerializer was calling JSON.stringify on all non-FormData bodies, including strings that are already serialized. This caused string values to gain an extra layer of JSON quoting (e.g. "hello" became '"hello"'). Add an early return for string bodies so they are sent as-is. Fixes openapi-ts#2555
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultBodySerializerwas callingJSON.stringifyon all non-FormDatabodies, including strings that are already serializedbody: "pre-serialized string"would become'"pre-serialized string"'(double-quoted) in the requestTest plan
body: ""updated to expect empty string passthrough (was"")string body is passed through without JSON serializationcovers non-empty string bodiesFixes #2555