fix(openapi-typescript): guard Readable/Writable against branded primitive types#2766
Open
deej-io wants to merge 1 commit intoopenapi-ts:mainfrom
Open
fix(openapi-typescript): guard Readable/Writable against branded primitive types#2766deej-io wants to merge 1 commit intoopenapi-ts:mainfrom
deej-io wants to merge 1 commit intoopenapi-ts:mainfrom
Conversation
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
|
…itive types
`string & { __brand: "UserId" }` satisfies `extends object`, so Readable/Writable
was mapping over all string prototype methods instead of returning the type as-is.
Adds a primitive guard before `extends object` in both types. Fix applied to both
READ_WRITE_HELPER_TYPES in src/transform/index.ts and openapi-typescript-helpers.
deej-io
force-pushed
the
fix/readable-writable-branded-primitives
branch
from
d06e072 to
a863f27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2765
string & { __brand: "UserId" }satisfiesT extends object, soReadable<T>andWritable<T>were mapping over all primitive prototype methods instead of returning the type as-is.Adds
T extends string | number | boolean | bigint | symbol ? T :before theextends objectbranch in both types. Applied toopenapi-typescript-helpers/src/index.tsandREAD_WRITE_HELPER_TYPESinsrc/transform/index.ts.