also print 'BAO_...' env variables

[phil9909]

Following the steps in the readme did not work for me, because I had a BAO_TOKEN and BAO_ADDR set in my env and . <(devbao node env prod) will only set the VAULT_... env vars.

bao secrets list will prefer the BAO_ vars and only fall back to VAULT_ if they are not present.

My proposed solution: Just print them both, this way we keep compatibility with the vault cli.

---

In case you are wondering, I have this in my .bashrc:

export BAO_ADDR='http://127.0.0.1:8200'
export BAO_TOKEN='root'
alias baodev='bao server -dev -dev-root-token-id=root'

which is quite handy for quick testing

[satoqz]

Would printing the right prefix based on n.Type work? OpenBao will always prefer BAO_* anyway, the only reason to print VAULT_* at all is the included Vault support unless I misunderstand.

[cipherboy]

@satoqz Tbf, at this point, I'm probably fine dropping Vault support from our tool unless someone really wants it.

[phil9909]

The VAULT_... env variables are useful for testing OpenBao server compatibility with Vault clients without explicit OpenBao support. (E.g. the vault cli)

Otherwise, dropping Vault support (i.e. the ability to spin up a Vault node/cluster), seems fine to me.

[cipherboy]

Then if we're doing both, let's do both!

The comment on dropping Vault support was mostly from a server side PoV fwiw.