Fix warning wrongly appearing on template change#1584
Fix warning wrongly appearing on template change#1584Arnei wants to merge 1 commit intoopencast:r/19.xfrom
Conversation
When changing the template in the acl tab, if the current acl settings were invalid, a warning would appear *after* the template change about how the acl was invalid, when due to the template change it actually no longer wasn't. This fixes that.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1584/2026-04-23_08-42-31/ . |
|
Maybe I'm doing something wrong here, but the default |
|
At the very least we should not claim that an ACL needs at least one read/write role, and then violate that claim by having a template that is literally an empty ACL. Maybe add |
|
That would be functionally identical, but likely confusing for the user since they aren't listed in their own ACL... Could we have the UI default to showing the user as an at-least-read role configuration if an empty template is selected? If the user manually removes all of the roles the behaviour is correct, it's just loading an empty template that causes weirdness - I would expect that both a) all of the templates work, even if they don't do what I want (ie, I can lock myself out of my own video) I guess there's a discussion to be had about point a. Should we even allow that? |
|
The user itself is not listed in any of the templates. But the ACL tab in the event/series details makes sure to add the role of the user on template change, so that they are listed in their own ACL. If that does not happen for I am not an admin, but from what I hear, you basically never want to lock yourself out of your own video. It probably should remain technically possible for some edge cases I can't even imagine. But from a usability standpoint we should ensure that a user never accidentally loses rights on their own video, only very deliberately. |
When changing the template in the acl tab, if the current acl settings were invalid, a warning would appear after the template change about how the acl was invalid, when due to the template change it actually no longer wasn't.
This fixes that.
How to test this
Get your ACL to be invalid (by removing all roles, or by adding a new role and not selecting a role in the dropdown). Then change template.