docs(repair): clarify Node 22 notifier test cancelledByParent is environmental#54
Open
ds4psb-ai wants to merge 1 commit intoopenclaw:mainfrom
Open
Conversation
PR#53's Validation note flagged "two existing notifier tests with Node 22
cancelledByParent". The repo's engines.node is >=24, so Node 22 is
unsupported, but install does not enforce engine-strict and the false
alarm has now surfaced twice.
Verified all 22 notifier tests pass cleanly on Node 24.14.0 and 25.6.1
(node --test test/repair/notify-{events,merge,github-activity}.test.ts).
The 5-second retry-path tests trip the older node:test runner; on
supported Node they finish without cancellation.
Add a short note to AGENTS.md so the next contributor running on Node 22
knows the failure is environmental, not a regression.
ds4psb-ai
pushed a commit
to ds4psb-ai/clawsweeper
that referenced
this pull request
May 8, 2026
Contributor
Author
|
@clawsweeper review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR#53's body noted that two notifier tests fail with
cancelledByParentunder Node 22. The repo'sengines.nodeis>=24, so Node 22 is unsupported, butengine-strictis not enforced —pnpm installsucceeds with only a warning, then the failure surfaces at test time and looks like a regression. This PR documents that the failure is environmental, so the next contributor doesn't lose time chasing a phantom bug.Reproduction
>=24, both supported)test/repair/notify-events.test.ts(5 tests, includes a 5s retry-path case)test/repair/notify-merge.test.ts(9 tests)test/repair/notify-github-activity.test.ts(8 tests, includes a 5s retry-path case)0 cancelled,0 failed. Fullpnpm run test:repairis also green at 242/242.The two long-running tests (
runClawSweeperEventNotifier covers skip, config, dry-run, and strict failure pathsandrunGithubActivityNotifier covers skip, dry-run, deliver, and failure paths) exercise retry+backoff paths that take ~5s end-to-end. The oldernode:testrunner in Node 22 has known timing quirks for tests of this shape, which is what surfaced ascancelledByParentin PR#53's local run. On Node 24+ the runner handles them correctly.What changed
AGENTS.md: added a one-paragraph note to the Commands section pointing out that Node 22 will install (noengine-strict) but trips the notifier tests' retry paths under the oldnode:testrunner.No source or test code is touched — verification confirmed there is no Node 24 bug to fix.
Validation
node --test test/repair/notify-events.test.ts test/repair/notify-merge.test.ts test/repair/notify-github-activity.test.tson Node 24.14.0 and 25.6.1 → 22/22 pass, 0 cancelledpnpm run test:repair→ 242/242 pass, 0 cancelledpnpm run format:check→ cleanScope discipline
Touches only
AGENTS.md. Does NOT modifysrc/clawsweeper.ts,src/repair/comment-router*(PR#50),src/repair/github-cli.ts/plan-cluster.ts(PR#49), orsrc/policy-rfc/**. No conflict with in-flight PRs.