Fix: Critical login state and authentication issues #60

zerox80 · 2025-11-21T08:51:33Z

Fix: Critical Login State Loss & Authentication Issues

📋 Overview

This PR resolves critical issues in the login process, specifically regarding OAuth authentication (OIDC). The primary issue was that the LoginActivity state (and thus crucial authentication parameters) was lost when the user switched to the browser view (Custom Tabs) and returned. This resulted in login failures or app crashes/restarts, particularly on devices with aggressive memory management.

🐛 The Problem

When the app opens the browser for OAuth login, LoginActivity is pushed to the background. Android may terminate the app process at this point to reclaim memory.
When the user returns after logging in:

LoginActivity is recreated (onCreate).
All in-memory variables (like codeVerifier, codeChallenge, serverBaseUrl) are gone.
The app no longer knows where to connect or how to verify the received "Auth Code".
Result: Login fails or the app returns to the start screen (URL input field), forcing the user to re-enter the URL even though they had already done so. This commonly occurred when switching apps, for example, to copy credentials from a Password Manager.

🛠 The Solution

The solution consists of three main components:

Persistent Storage (SharedPreferences): Critical OAuth parameters (codeVerifier, codeChallenge, oidcState) are now explicitly saved to SharedPreferences before the browser is opened. This is more robust than onSaveInstanceState as it survives complete process restarts.
State Restoration: In onCreate and onSaveInstanceState, the UI state (URL input, Auth method) is now correctly saved and restored.
Intent Handling (SingleTop): Prevents a new instance of LoginActivity from being placed on the stack when the browser returns. Instead, the existing instance is reused.

🔍 Detailed Code Analysis

1. `AuthenticationViewModel.kt` - Mutability for Restore

We need to make the OAuth parameters mutable so we can overwrite them when restoring the old state from storage.

// BEFORE: Immutable values (val), generated when the class was created
// val codeVerifier: String = OAuthUtils().generateRandomCodeVerifier()

// AFTER: Mutable values (var), so we can overwrite them
// when restoring the old state.
var codeVerifier: String = OAuthUtils().generateRandomCodeVerifier()
var codeChallenge: String = OAuthUtils().generateCodeChallenge(codeVerifier)
var oidcState: String = OAuthUtils().generateRandomState()

2. `LoginActivity.kt` - Intent & Task Management

When the browser returns with the Auth Code, we don't want Android to layer a new LoginActivity over the old one. We want to reactivate the old one.

override fun onCreate(savedInstanceState: Bundle?) {
    // Check if we are returning via a Redirect (Deep Link) with an Auth Code
    if (intent.data != null && (intent.data?.getQueryParameter("code") != null || intent.data?.getQueryParameter("error") != null)) {
        if (!isTaskRoot) {
            // IMPORTANT: If we are not the root activity, bring the existing instance to the front.
            // FLAG_ACTIVITY_CLEAR_TOP: Removes everything that might be above LoginActivity.
            // FLAG_ACTIVITY_SINGLE_TOP: Uses the existing instance (calls onNewIntent) instead of creating a new one.
            val newIntent = Intent(this, LoginActivity::class.java)
            newIntent.data = intent.data
            newIntent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP or Intent.FLAG_ACTIVITY_SINGLE_TOP)
            startActivity(newIntent)
            finish()
            return
        }
    }
    super.onCreate(savedInstanceState)
    // ...

3. `LoginActivity.kt` - Saving & Loading Auth State

Here lies the magic of persistence. We don't just rely on RAM.

Saving before Browser Launch:

private fun startOAuthAuthorization(...) {
    // ...
    try {
        // BEFORE opening the browser, we save everything securely to "disk" (SharedPreferences).
        saveAuthState() 
        customTabsIntent.launchUrl(this, authorizationEndpointUri)
    } catch (e: Exception) { ... }
}

private fun saveAuthState() {
    val prefs = getSharedPreferences("auth_state", android.content.Context.MODE_PRIVATE)
    prefs.edit().apply {
        // We save the cryptographic keys needed to verify the login.
        putString(KEY_CODE_VERIFIER, authenticationViewModel.codeVerifier)
        putString(KEY_CODE_CHALLENGE, authenticationViewModel.codeChallenge)
        putString(KEY_OIDC_STATE, authenticationViewModel.oidcState)
        apply()
    }
}

Restoring on Start (onCreate):

// In onCreate...
} else {
    // If savedInstanceState exists (e.g., screen rotated or restored by system)
    authTokenType = savedInstanceState.getString(KEY_AUTH_TOKEN_TYPE)
    
    // Restore Server URL so the input field isn't empty
    savedInstanceState.getString(KEY_SERVER_BASE_URL)?.let { serverBaseUrl = it }
    oidcSupported = savedInstanceState.getBoolean(KEY_OIDC_SUPPORTED)

    // Restore ViewModel data from Bundle
    savedInstanceState.getString(KEY_CODE_VERIFIER)?.let { authenticationViewModel.codeVerifier = it }
    // ...
}

// ... further down in onCreate ...

// If we return with an Auth Code (Intent Data has "code")
if (intent.data != null && (intent.data?.getQueryParameter("code") != null ...)) {
    // If savedInstanceState is null (e.g., process was completely dead),
    // we try to rescue the state from SharedPreferences.
    if (savedInstanceState == null) {
        restoreAuthState()
    }
    handleGetAuthorizationCodeResponse(intent)
}

Cleanup on Success:

// If login was successful, we delete the temporary data.
private fun onAccountCreationSuccessful(...) {
    // ...
    clearAuthState()
}

4. `LoginActivity.kt` - UI State Restoration

We ensure that the UI (input fields, button visibility) is correctly restored so the user isn't faced with an empty screen.

// Restore UI state
if (::serverBaseUrl.isInitialized && serverBaseUrl.isNotEmpty()) {
    binding.hostUrlInput.setText(serverBaseUrl)
    
    // Show correct fields (Basic Auth vs. OAuth) based on previous state
    if (authTokenType == BASIC_TOKEN_TYPE) {
        showOrHideBasicAuthFields(shouldBeVisible = true)
    } else if (authTokenType == OAUTH_TOKEN_TYPE) {
        showOrHideBasicAuthFields(shouldBeVisible = false)
    }
}

✅ Verification / Testing

Scenario: Simulate Process Death
- Open App -> Enter Server URL -> Click "Connect".
- Browser opens for login.
- Now: Switch to a different App (Password Manager)
- Return to browser -> Complete login.
- Expectation: App opens, does NOT crash, login completes successfully.
Scenario: Normal Flow
- Standard login flow without interruption.
- Expectation: Works as before, no regressions.

Notice: I utilized Gemini 3 Pro to accelerate the development of this PR. Therefore, I consider a single-person review (2-eye principle) insufficient. I strictly prefer a 4-eye principle review by another contributor to ensure correctness.

zerox80 · 2025-11-22T11:25:15Z

Notice: I utilized Gemini 3 Pro to accelerate the development of this PR. Therefore, I consider a single-person review (2-eye principle) insufficient. I strictly prefer a 4-eye principle review by another contributor to ensure correctness.

guruz · 2026-01-12T14:07:01Z

Looks fine in general 👍 I will give it a test

guruz · 2026-01-12T16:02:55Z

opencloudApp/src/main/java/eu/opencloud/android/MainApp.kt

        SingleSessionManager.setUserAgent(userAgent)

        // initialise thumbnails cache on background thread
-        ThumbnailsCacheManager.InitDiskCacheTask().execute()


@zerox80 Why is this line here?
If this is a glitch from something else, can you please re-base this PR so we see if it's still there?

its not glitch from something else, i always rebase all PRs after u merge something. What do u mean ? im confused

guruz · 2026-01-12T16:20:26Z

New app installation, fails immediatly after initial launch (I can still accept that the app sends me notifications)

01-12 17:16:37.513 32691 32691 D AndroidRuntime: Shutting down VM
01-12 17:16:37.514 32691 32691 E AndroidRuntime: FATAL EXCEPTION: main
01-12 17:16:37.514 32691 32691 E AndroidRuntime: Process: eu.opencloud.android.debug, PID: 32691
01-12 17:16:37.514 32691 32691 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{eu.opencloud.android.debug/eu.opencloud.android.presentation.authentication.LoginActivity}: java.lang.IllegalStateException: SavedStateRegistry was already restored.
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4280)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:4467)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:222)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:133)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:103)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2823)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:110)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:248)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:338)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:9067)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:932)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: Caused by: java.lang.IllegalStateException: SavedStateRegistry was already restored.
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at androidx.savedstate.SavedStateRegistry.performRestore$savedstate_release(SavedStateRegistry.kt:221)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at androidx.savedstate.SavedStateRegistryController.performRestore(SavedStateRegistryController.kt:69)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:361)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at eu.opencloud.android.presentation.authentication.LoginActivity.onCreate(LoginActivity.kt:140)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:9155)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:9133)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1521)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4262)
01-12 17:16:37.514 32691 32691 E AndroidRuntime: 	... 13 more
01-12 17:16:37.519   676  1500 W ActivityTaskManager:   Force finishing activity eu.opencloud.android.debug/eu.opencloud.android.presentation.authentication.LoginActivity

Might also be fishy that I see super.onCreate(savedInstanceState)called twice from same function

zerox80 · 2026-01-12T16:21:56Z

yes i solved that super stuff in other PR xD

zerox80 · 2026-01-12T16:22:43Z

will focus this PR soon, i am cooking stuff with conflict management while syncing.

guruz · 2026-01-12T16:23:58Z

OK, yes, rebase because I think all the stuff in ic_action_open_shortcut.xml is also not relevant herew :-)

…various service instances.

… prevent login failure after process death

…omTabsIntent for Firefox compatibility - Add setIntent() in onNewIntent to properly handle OAuth redirects - Add logging for OAuth redirect debugging

…iling whitespace

…crash

zerox80 · 2026-01-12T16:51:59Z

@guruz

zerox80 force-pushed the fix/login-issues branch 2 times, most recently from dc63785 to 6b37d75 Compare November 21, 2025 09:02

zerox80 mentioned this pull request Nov 21, 2025

Feature: Thumbnail Cache Improvements #50

Open

zerox80 force-pushed the fix/login-issues branch from cf23ce7 to 3cfa0d8 Compare November 25, 2025 10:21

guruz reviewed Jan 12, 2026

View reviewed changes

zerox80 added 8 commits January 12, 2026 17:45

Fix: Critical login state and authentication issues

19b5f1a

feat: Add ClientManager for managing OpenCloud clients and providing …

1a238ce

…various service instances.

Fix: Save OAuth state (codeVerifier, state) in onSaveInstanceState to…

6aa43f9

… prevent login failure after process death

Fix: Add missing super.onCreate call in LoginActivity

5769557

Fix Firefox OAuth redirect issue - Add FLAG_ACTIVITY_NEW_TASK to Cust…

6c5f0f9

…omTabsIntent for Firefox compatibility - Add setIntent() in onNewIntent to properly handle OAuth redirects - Add logging for OAuth redirect debugging

Fix detekt trailing whitespace and spacing issues

6f70a7e

Fix detekt issues in ClientManagerTest: remove unused imports and tra…

0119d3c

…iling whitespace

Fix: Remove duplicate super.onCreate call causing SavedStateRegistry …

5586f7e

…crash

zerox80 force-pushed the fix/login-issues branch from bfbce96 to 5586f7e Compare January 12, 2026 16:45

zerox80 added 4 commits January 12, 2026 17:54

Fix: Restore ThumbnailsCacheManager call unintentionally removed

0aa6aa1

Fix: Remove duplicate import

f33394c

Fix: Restore missing Java file and resolve merge conflict

bf69b28

Fix: Add missing pendingAuthorizationIntent declaration

0dcf9e3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Critical login state and authentication issues #60

Fix: Critical login state and authentication issues #60

Uh oh!

zerox80 commented Nov 21, 2025 •

edited

Loading

Uh oh!

zerox80 commented Nov 22, 2025

Uh oh!

guruz commented Jan 12, 2026

Uh oh!

guruz Jan 12, 2026

Uh oh!

zerox80 Jan 12, 2026

Uh oh!

guruz commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

guruz commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix: Critical login state and authentication issues #60

Are you sure you want to change the base?

Fix: Critical login state and authentication issues #60

Uh oh!

Conversation

zerox80 commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix: Critical Login State Loss & Authentication Issues

📋 Overview

🐛 The Problem

🛠 The Solution

🔍 Detailed Code Analysis

1. AuthenticationViewModel.kt - Mutability for Restore

2. LoginActivity.kt - Intent & Task Management

3. LoginActivity.kt - Saving & Loading Auth State

4. LoginActivity.kt - UI State Restoration

✅ Verification / Testing

Uh oh!

zerox80 commented Nov 22, 2025

Uh oh!

guruz commented Jan 12, 2026

Uh oh!

guruz Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

guruz commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

guruz commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zerox80 commented Nov 21, 2025 •

edited

Loading

1. `AuthenticationViewModel.kt` - Mutability for Restore

2. `LoginActivity.kt` - Intent & Task Management

3. `LoginActivity.kt` - Saving & Loading Auth State

4. `LoginActivity.kt` - UI State Restoration