Feature/download sync #79

zerox80 · 2026-01-10T11:09:48Z

Download and Sync Feature

Summary

This PR adds the ability to download all files from the server and keep them synchronized locally. Users can now enable offline access for their entire account through the settings.

Changes

External Storage with Human-Readable Folder Names

Files are now stored in External storage with clear, readable folder names
Improved file organization for better user experience

Sync Option and Download All Files

Added new sync settings in the Security/Privacy section
Implemented DownloadEverythingWorker to handle bulk downloads
Implemented LocalFileSyncWorker to keep local files in sync with the server
Users can enable/disable the sync feature through settings

Worker Improvements

Fixed DownloadEverythingWorker to properly iterate through all folders and files
Improved error handling and progress reporting
Added proper recursive folder traversal

Localization

Changed German storage permission dialog text to English for consistency

Testing

Tested download of multiple files and folders
Verified sync worker runs correctly in the background
Confirmed files are stored in the correct external storage location

Related Issues

#24

- Switch to External Storage Directory in ScopedStorageProvider. - Request MANAGE_EXTERNAL_STORAGE permission on Android R+. - Use Space names instead of IDs for folder structure. - Rename data folder to OpenCloud.

…iles - Root cause: refreshFolder() only returned changed files, not all - Solution: Use getFolderContent(folderId) after refresh to get ALL files from DB - Add recursive folder traversal with proper refresh before each folder scan - Improve LocalFileSyncWorker with better statistics and notifications - Remove setForegroundAsync to fix Android 14+ foreground service crash

samolego · 2026-01-11T09:00:36Z

This is a killer feature!
Question: what happens on file conflicts, e.g. if file is edited on web and on the device? How is synchronization handled?

Also, how does background sync work in regards of battery management in Android?

Changed avatar endpoint from legacy /index.php/avatar/ to /graph/v1.0/me/photo/ for openCloud compatibility.

When a file changes both locally and remotely, automatically upload the local version instead of requiring manual conflict resolution. This provides a seamless auto-sync experience (last write wins).

zerox80 · 2026-01-12T12:34:22Z

This is a killer feature! Question: what happens on file conflicts, e.g. if file is edited on web and on the device? How is synchronization handled?

Also, how does background sync work in regards of battery management in Android?

When a file changes both locally and remotely, automatically upload
the local version instead of requiring manual conflict resolution.
This provides a seamless auto-sync experience (last write wins).

https://github.com/zerox80/android/releases

samolego · 2026-01-12T15:13:09Z

When a file changes both locally and remotely, automatically upload
the local version instead of requiring manual conflict resolution.
This provides a seamless auto-sync experience (last write wins).

I don't think that's the best way to handle this. Desktop version pulls the file on conflict and names it _conflicted_copy or sth. similar.

I think we shouldn't be overwriting remote work, at least not without user confirmation.

samolego · 2026-01-11T08:55:05Z

opencloudApp/src/main/java/eu/opencloud/android/ui/activity/FileDisplayActivity.kt

+            if (!android.os.Environment.isExternalStorageManager()) {
+                val builder = AlertDialog.Builder(this)
+                builder.setTitle(getString(R.string.app_name))
+                builder.setMessage("To save offline files, the app needs access to all files.")


This strings should probably be translated

Yes, can do micro patch later

lets have focus on implementing the sync stuff perfectly, translation etc can be done later

samolego · 2026-01-11T08:56:03Z

opencloudApp/src/main/res/values/setup.xml

    <string name="db_file" formatted="false">opencloud.db</string>
    <string name="db_name" formatted="false">OpenCloud</string>
-    <string name="data_folder" formatted="false">opencloud</string>
+    <string name="data_folder" formatted="false">OpenCloud</string>


Is this necesarry?

looks better

zerox80 · 2026-01-12T15:20:59Z

When a file changes both locally and remotely, automatically upload
the local version instead of requiring manual conflict resolution.
This provides a seamless auto-sync experience (last write wins).

I don't think that's the best way to handle this. Desktop version pulls the file on conflict and names it _conflicted_copy or sth. similar.

I think we shouldn't be overwriting remote work, at least not without user confirmation.

But whats issue with last write win strategy? The manual user interaction is really bad UX, the Sync before that sync rework worked, but showed conflict. Its just very very unlikely that it will become an issue. The overwrite happens only if i change the file and save it. I think UX should imo have more priority, cuz thats a ~1% chance that it causes issues

zerox80 · 2026-01-12T15:23:00Z

When a file changes both locally and remotely, automatically upload
the local version instead of requiring manual conflict resolution.
This provides a seamless auto-sync experience (last write wins).

I don't think that's the best way to handle this. Desktop version pulls the file on conflict and names it _conflicted_copy or sth. similar.
I think we shouldn't be overwriting remote work, at least not without user confirmation.

But whats issue with last write win strategy? The manual user interaction is really bad UX, the Sync before that sync rework worked, but showed conflict. Its just very very unlikely that it will become an issue. The overwrite happens only if i change the file and save it. I think UX should imo have more priority, cuz thats a ~1% chance that it causes issues

So should we just add the conflict stuff again with a easy option "last write win" ? how should it be solved without causing a really really bad UX?

zerox80 · 2026-01-12T15:27:48Z

This is a killer feature! Question: what happens on file conflicts, e.g. if file is edited on web and on the device? How is synchronization handled?

Also, how does background sync work in regards of battery management in Android?

Have to test it, but i didn't have both open at same time. I only tested editing something, closing on web, editing 2 seconds later on Android. I planned to test that scenario today

zerox80 · 2026-01-12T15:37:24Z

@samolego
You're right that data safety should be prioritized. I'll implement a conflicted copy approach similar to the desktop version:

When both local and remote have changed, download the remote version AND keep the local file renamed as filename_conflicted_copy_.ext
This ensures no data loss while still avoiding manual intervention
The user can then compare and decide which version to keep

…e is modified both locally and remotely, create a conflicted copy of the local file and download the remote version. This ensures no data loss, matching desktop client behavior.

…es the conflicted copy visible in the app's file list immediately after sync conflict resolution

… in Security settings to choose conflict resolution strategy - When enabled: upload local version (overwrites remote) - When disabled (default): create conflicted copy and download remote - Ensures no data loss while giving users control over conflict behavior

…eSystemWorker now checks for conflicts when forceOverwrite=true - Creates local conflicted copy before uploading when remote changed - Respects 'prefer local on conflict' setting - Works even without Auto-Sync enabled

zerox80 · 2026-01-12T16:38:38Z

Please test it, and give feedback.
Theres option now with always last write wins (default: Off)

edit: Conflict files are in the OpenCloud Folder, not on Server

zerox80 · 2026-01-13T10:12:46Z

https://github.com/zerox80/android/releases/tag/2.0.11

zerox80 added 4 commits January 10, 2026 12:13

feat: use external storage with human-readable folder names

6cb7aa1

- Switch to External Storage Directory in ScopedStorageProvider. - Request MANAGE_EXTERNAL_STORAGE permission on Android R+. - Use Space names instead of IDs for folder structure. - Rename data folder to OpenCloud.

Sync Option + Download all files

aa6841e

fix(i18n): Change German storage permission dialog to English

0f69672

zerox80 force-pushed the feature/download-sync branch from 187f570 to 0f69672 Compare January 10, 2026 11:13

zerox80 added 2 commits January 11, 2026 21:03

fix: Use Graph API endpoint for user avatars

aa7f0bd

Changed avatar endpoint from legacy /index.php/avatar/ to /graph/v1.0/me/photo/ for openCloud compatibility.

fix: Auto-resolve sync conflicts by uploading local version

821a2a0

When a file changes both locally and remotely, automatically upload the local version instead of requiring manual conflict resolution. This provides a seamless auto-sync experience (last write wins).

samolego suggested changes Jan 12, 2026

View reviewed changes

zerox80 added 5 commits January 12, 2026 16:46

feat: Auto-resolve sync conflicts with conflicted copies - When a fil…

61fa9cf

…e is modified both locally and remotely, create a conflicted copy of the local file and download the remote version. This ensures no data loss, matching desktop client behavior.

feat: Refresh parent folder after creating conflicted copy - This mak…

8fd7fa8

…es the conflicted copy visible in the app's file list immediately after sync conflict resolution

fix: Use actual file modification time for local change detection

519ec32

Feature/download sync #79

Are you sure you want to change the base?

Feature/download sync #79

Conversation

zerox80 commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Download and Sync Feature

Summary

Changes

External Storage with Human-Readable Folder Names

Sync Option and Download All Files

Worker Improvements

Localization

Testing

Related Issues

Uh oh!

samolego commented Jan 11, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

samolego commented Jan 12, 2026

Uh oh!

samolego Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

samolego Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026

Uh oh!

zerox80 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zerox80 commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zerox80 commented Jan 10, 2026 •

edited

Loading

zerox80 commented Jan 12, 2026 •

edited

Loading