fix: correct push remote_url for typescript-axios pipeline#40
Open
dschmidt wants to merge 1 commit intoopencloud-eu:mainfrom
Open
fix: correct push remote_url for typescript-axios pipeline#40dschmidt wants to merge 1 commit intoopencloud-eu:mainfrom
dschmidt wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
The push step in build-typescript-axios.yaml pointed to the Go client repository instead of the typescript-axios repository. Currently harmless because wp-git-action pushes via the cloned remote, but a behavior change in the plugin could route generated TypeScript code into the Go repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
push_target_repostep in.woodpecker/build-typescript-axios.yamlpointedremote_urlat the Go client repo instead oflibre-graph-api-typescript-axios.Currently without consequenes -
wp-git-actionpushes via the remote of the cloned working copy, so generated code lands in the right place - but the mismatch becomes a real bug if the plugin ever honorsremote_urlon push.