Skip to content

feat(web): introduce dynamic theme management via RPC #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fschade wants to merge 2 commits into
base: main
Choose a base branch
from

fix: remove web theme cs3 metadata fs and use the host fs instead

979c8a1
Select commit
Loading
Failed to load commit list.
Draft

feat(web): introduce dynamic theme management via RPC #2651

fix: remove web theme cs3 metadata fs and use the host fs instead
979c8a1
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 23, 2026 in 59s

Quality Gate failed

Failed conditions
10.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 164 in services/web/pkg/config/defaults/defaultconfig.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEKc9z6hsX0ARdO9&open=AZ21AEKc9z6hsX0ARdO9&pullRequest=2651

Check warning on line 372 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "file_opencloud_services_web_v0_web_proto_rawDescGZIP" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO6&open=AZ21AEIX9z6hsX0ARdO6&pullRequest=2651

Check failure on line 138 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO2&open=AZ21AEIX9z6hsX0ARdO2&pullRequest=2651

Check failure on line 277 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO5&open=AZ21AEIX9z6hsX0ARdO5&pullRequest=2651

Check failure on line 46 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO0&open=AZ21AEIX9z6hsX0ARdO0&pullRequest=2651

Check failure on line 98 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO1&open=AZ21AEIX9z6hsX0ARdO1&pullRequest=2651

Check failure on line 232 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO4&open=AZ21AEIX9z6hsX0ARdO4&pullRequest=2651

Check failure on line 26 in services/web/pkg/command/server.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEK99z6hsX0ARdPA&open=AZ21AEK99z6hsX0ARdPA&pullRequest=2651

Check warning on line 21 in services/web/pkg/server/grpc/option.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEKt9z6hsX0ARdO-&open=AZ21AEKt9z6hsX0ARdO-&pullRequest=2651

Check failure on line 403 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO7&open=AZ21AEIX9z6hsX0ARdO7&pullRequest=2651

Check warning on line 10 in services/web/pkg/fs/fs.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Take the required action to fix the issue indicated by this "FIXME" comment. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ26ti7jAOCFSQDZnsiB&open=AZ26ti7jAOCFSQDZnsiB&pullRequest=2651

Check warning on line 403 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "file_opencloud_services_web_v0_web_proto_init" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO8&open=AZ21AEIX9z6hsX0ARdO8&pullRequest=2651

Check failure on line 80 in services/web/pkg/command/server.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Failed to initialize server" 3 times. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEK99z6hsX0ARdO_&open=AZ21AEK99z6hsX0ARdO_&pullRequest=2651

Check failure on line 185 in protogen/gen/opencloud/services/web/v0/web.pb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=opencloud-eu_opencloud&issues=AZ21AEIX9z6hsX0ARdO3&open=AZ21AEIX9z6hsX0ARdO3&pullRequest=2651
View more details on SonarQubeCloud