Skip to content

fix(webdav): register chi REPORT method in init to avoid race with settings #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −3
Open

fix(webdav): register chi REPORT method in init to avoid race with settings #2712

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25d383
fix(webdav): register chi REPORT method in init to avoid race
May 5, 2026
274c067
chore: drop changelog entry per review
SAY-5 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions services/webdav/pkg/service/v0/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@ var (
}
)

// register the WebDAV REPORT method with chi at package init time.
// chi.RegisterMethod mutates a package-global map in github.com/go-chi/chi/v5
// (methodMap) which is also read by (*node).setEndpoint during route insertion.
// When opencloud runs services concurrently via the suture supervisor, calling
// chi.RegisterMethod inside NewService races with route registration in other
// services (e.g. settings) and triggers a "concurrent map iteration and map
// write" runtime panic in chi/tree.go:setEndpoint. Doing it in init() runs
// before any service goroutine is spawned and is safe.
func init() {
chi.RegisterMethod("REPORT")
}

// Service defines the extension handlers.
type Service interface {
ServeHTTP(w http.ResponseWriter, r *http.Request)
Expand Down Expand Up @@ -93,9 +105,6 @@ func NewService(opts ...Option) (Service, error) {
svc.thumbnailsClient = nil
}

// register method with chi before any routing is set up
chi.RegisterMethod("REPORT")

m.Route(options.Config.HTTP.Root, func(r chi.Router) {

if !svc.config.DisablePreviews {
Expand Down