Skip to content

Adding test for ACCTZ-8.1#5404

Open
Steubert wants to merge 3 commits intoopenconfig:mainfrom
open-traffic-generator:FPT_OTG_ACCTZ-8.1
Open

Adding test for ACCTZ-8.1#5404
Steubert wants to merge 3 commits intoopenconfig:mainfrom
open-traffic-generator:FPT_OTG_ACCTZ-8.1

Conversation

@Steubert
Copy link
Copy Markdown

@Steubert Steubert requested a review from a team as a code owner April 30, 2026 10:15
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test case to verify the gNSI accounting functionality on a device under test (DUT) when authentication fails. It ensures that the device correctly generates and reports accounting records for various gRPC services under different failure conditions, such as incorrect credentials or invalid TLS certificates. The implementation leverages the existing featureprofiles test framework to perform these validations in a systematic and automated manner.

Highlights

  • New Test Implementation: Added a comprehensive test suite for ACCTZ-8.1 to validate gNSI accounting records during authentication failure scenarios.
  • Table-Driven Testing: Implemented a robust table-driven testing approach covering multiple gRPC services (gNMI, gNOI, gNSI, gRIBI, P4RT) and various credential failure scenarios.
  • In-Memory Certificate Generation: Added utility functions to generate self-signed TLS client certificates in-memory to simulate authentication failures without requiring external files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the AccountingAuthenFailUni test, which validates gNSI accounting for authentication failures across gNMI, gNOI, gNSI, gRIBI, and P4RT services. The test simulates various failure scenarios, such as incorrect passwords and invalid certificates, and verifies the accuracy of the generated accounting records. The review feedback recommends using the correct streaming client for gNSI and removing redundant timer logic in the record collection helper.

@ksgireesha ksgireesha requested a review from a team May 5, 2026 05:41
@ksgireesha
Copy link
Copy Markdown

@ram-mac , we have LGTM by @seal6363 . Please review and approve this PR

@ram-mac
Copy link
Copy Markdown
Contributor

ram-mac commented May 6, 2026

Validation of this test is failing on Arista device. Please take a look at the fail logs here
https://partnerissuetracker.corp.google.com/u/1/issues/508075503#comment3

@Steubert
Copy link
Copy Markdown
Author

Steubert commented May 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants