Adding test for ACCTZ-8.1#5404
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new test case to verify the gNSI accounting functionality on a device under test (DUT) when authentication fails. It ensures that the device correctly generates and reports accounting records for various gRPC services under different failure conditions, such as incorrect credentials or invalid TLS certificates. The implementation leverages the existing featureprofiles test framework to perform these validations in a systematic and automated manner. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the AccountingAuthenFailUni test, which validates gNSI accounting for authentication failures across gNMI, gNOI, gNSI, gRIBI, and P4RT services. The test simulates various failure scenarios, such as incorrect passwords and invalid certificates, and verifies the accuracy of the generated accounting records. The review feedback recommends using the correct streaming client for gNSI and removing redundant timer logic in the record collection helper.
|
Validation of this test is failing on Arista device. Please take a look at the fail logs here |
README Location: https://github.com/openconfig/featureprofiles/blob/main/feature/gnsi/acctz/tests/AccountingAuthenFailUni/README.md
Raised an issue for the failure https://partnerissuetracker.corp.google.com/u/1/issues/507318970
Logs Attached: https://partnerissuetracker.corp.google.com/u/1/issues/508075503