libct: deprecate libcontainer/devices in favour of moby/sys/devices#5142
Merged
kolyshkin merged 1 commit intoopencontainers:mainfrom Apr 3, 2026
Merged
Conversation
cyphar
force-pushed
the
deprecate-libct-devices
branch
2 times, most recently
from
97ce3a3 to
783bf93
Compare
Contributor
|
The devices package is now part of moby/sys: https://github.com/moby/sys/releases/tag/devices%2Fv0.1.0. I suggest to make this into v1.5.0rc2 and remove devices package from runc in v1.6. |
kolyshkin
added
the
backport/1.5-todo
Member
Author
|
Oh, I forgot I already had a PR opened and so I opened #5213. 🤦 Let me close that one and push it here. |
cyphar
force-pushed
the
deprecate-libct-devices
branch
2 times, most recently
from
3748ef2 to
1a1b485
Compare
cyphar
changed the title
The libcontainer/devices package has been moved to moby/sys/devices, so we can just point users to that and keep some compatibility shims around until runc 1.6. We don't use it at all so there are no other changes needed. Signed-off-by: Aleksa Sarai <aleksa@amutable.com>
cyphar
force-pushed
the
deprecate-libct-devices
branch
from
1a1b485 to
b345c78
Compare
kolyshkin
approved these changes
Apr 2, 2026
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM (one minor nit, feel free to ignore)
Comment on lines
+1
to
+2
| //go:build !windows | ||
|
|
Contributor
There was a problem hiding this comment.
nit: I don't think this is needed, the file has _unix in its name already. Won't hurt either though.
lifubang
approved these changes
Apr 2, 2026
kolyshkin
added
backport/1.5-done
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until #5141 and moby/sys#212 are merged.The libcontainer/devices package has been moved to moby/sys/devices, so
we can just point users to that and keep some compatibility shims around
until runc 1.6. We don't use it at all so there are no other changes
needed.
Signed-off-by: Aleksa Sarai aleksa@amutable.com