Skip to content

Create CIP#5

Closed
pontusmelke wants to merge 6 commits intoopencypher:masterfrom
pontusmelke:create-cip
Closed

Create CIP#5
pontusmelke wants to merge 6 commits intoopencypher:masterfrom
pontusmelke:create-cip

Conversation

@pontusmelke
Copy link

A CIP for CREATE

@petraselmer
Copy link

@pontusmelke, some changes were made to the CIP Template late yesterday afternoon. Please can you incorporate them?

@boggle
Copy link

boggle commented Oct 13, 2015

The grammar should be the kind of EBNF we have been using, mainly all production rules need to end with a single semicolon.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A "Retro CIP" like this, formalising/documenting an existing feature, I'm not convinced we strictly need a "Benefits" section. In this case the text here becomes very meta and contrived, so I'm thinking it is better to leave it out.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then what would be the benefit of this proposal?

@Mats-SX
Copy link

Mats-SX commented Oct 13, 2015

@thobe @petraselmer Seems we were updating concurrently. I'm pushing another commit to fix these comments soon.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than trying to contrive prose for the benefits and caveats sections, we could simply be straightforward and state that this is a retroactive CIP so some of these discussions don't apply.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"create new nodes and relationships into the graph" -> "add new nodes and relationships to the graph"

@systay
Copy link

systay commented Oct 27, 2015

replaced by #9

@systay systay closed this Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants