Skip to content

feat: add support for :host pseudo-class in style-dictionary output#4282

Open
xitij2000 wants to merge 1 commit intoopenedx:release-23.xfrom
open-craft:kshitij/root-and-host
Open

feat: add support for :host pseudo-class in style-dictionary output#4282
xitij2000 wants to merge 1 commit intoopenedx:release-23.xfrom
open-craft:kshitij/root-and-host

Conversation

@xitij2000
Copy link
Copy Markdown
Contributor

@xitij2000 xitij2000 commented May 9, 2026

Description

This PR updates the generated CSS variables from design tokens to emit variables under both :root and :host.

Previously, design token CSS variables were generated only under :root, which makes them globally available at the document level. This works well for normal application usage, but it does not fully support stylesheets that are loaded inside a Shadow DOM.

The primary use case for this change is to support isolated XBlocks that render inside a Shadow DOM. By including :host alongside :root, the XBlock can load these stylesheets with the theme remaining isolated to the XBlock without spilling over to the rest of the page.

Deploy Preview

NA. This should have no visual impact.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Enhanced the CSS output to include `:host` alongside `:root` for better compatibility with web components.

When using the stylesheets inside a shadow DOM, the `:root` selector doesn't match, and we need to use `:host` instead.
@netlify
Copy link
Copy Markdown

netlify Bot commented May 9, 2026

Deploy Preview for paragon-openedx-v23 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b7cf022
🔍 Latest deploy log https://app.netlify.com/projects/paragon-openedx-v23/deploys/69feeda849685400081c66e5
😎 Deploy Preview https://deploy-preview-4282--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels May 9, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @xitij2000!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.40%. Comparing base (9340b9c) to head (b7cf022).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-23.x    #4282   +/-   ##
=============================================
  Coverage         94.40%   94.40%           
=============================================
  Files               242      242           
  Lines              4309     4309           
  Branches            981      981           
=============================================
  Hits               4068     4068           
  Misses              237      237           
  Partials              4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants