feat: add support for :host pseudo-class in style-dictionary output#4282
feat: add support for :host pseudo-class in style-dictionary output#4282xitij2000 wants to merge 1 commit intoopenedx:release-23.xfrom
Conversation
Enhanced the CSS output to include `:host` alongside `:root` for better compatibility with web components. When using the stylesheets inside a shadow DOM, the `:root` selector doesn't match, and we need to use `:host` instead.
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for the pull request, @xitij2000! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4282 +/- ##
=============================================
Coverage 94.40% 94.40%
=============================================
Files 242 242
Lines 4309 4309
Branches 981 981
=============================================
Hits 4068 4068
Misses 237 237
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR updates the generated CSS variables from design tokens to emit variables under both
:rootand:host.Previously, design token CSS variables were generated only under
:root, which makes them globally available at the document level. This works well for normal application usage, but it does not fully support stylesheets that are loaded inside a Shadow DOM.The primary use case for this change is to support isolated XBlocks that render inside a Shadow DOM. By including
:hostalongside:root, the XBlock can load these stylesheets with the theme remaining isolated to the XBlock without spilling over to the rest of the page.Deploy Preview
NA. This should have no visual impact.
Merge Checklist
exampleapp?Post-merge Checklist