You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @Alonsoju95 ,
Last week we experimented with some problems related to the plotting function you wrote. Therefore it was deleted from dev. We agreed with @ClaraBuettner on not using new libraries that are not part of setup.py now, in order to avoid dependencies problems in the future. I already made some changes to your branch, so please double-check that everything is working correctly. From now on you will be responsible for this PR, so please take a look at the checkpoints at the beginning of this page and proceed consequently. Let me know in case you have any questions.
@CarlosEpia Hi Carlos! Ok! I saw that the lines for the osm were erased, I understand it is because of the dependencies. Do I have to find another way to draw an osm map in the plot?
@CarlosEpia Hi Carlos! Ok! I saw that the lines for the osm were erased, I understand it is because of the dependencies. Do I have to find another way to draw an osm map in the plot?
It's not necessary. Just follow the steps to merge the PR. Keep in mind that you need to merge it into the current CI branch, but first I would check what's wrong with one of the Git checks (Codacy Static Code Analysis).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #763.
Before merging into
dev-branch, please make sure thatCHANGELOG.rstwas updated.blackandisort.Dataset-version is updated when existing datasets are adjusted.continuous-integration/run-everything-over-the-weekend-branch.test mode.Everythingmode.