Draft
Conversation
…into feature/validation_integration # Conflicts: # src/egon/data/datasets/__init__.py
…into feature/validation_integration
…-integration' into feature/validation-sanity-checks-integration # Conflicts: # src/egon/data/validation/rules/custom/sanity/gas_grid.py
….com:openego/egon-data into feature/validation-sanity-checks-integration
Member
|
@sagemaso please make sure you follow the checklists above before converting to "ready for review". On the failing tox build: as mentioned it is related to #1386 and will be fixed by #1382 but this can take some time. |
…into feature/validation_integration # Conflicts: # src/egon/data/airflow/dags/pipeline.py # src/egon/data/datasets/DSM_cts_ind.py # src/egon/data/datasets/__init__.py # src/egon/data/datasets/vg250/__init__.py
…into feature/validation_integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes openego/eGon-validation#10 and openego/eGon-validation#11
🧑💻 Contributor Checklist
Before requesting a review, make sure you've completed all of the following:
(for more information on local test, check
toxin the Contributing section)(CI tests are automatically executed when creating a PR, you can see the results of the checks below)
(optional if no dataset changes are involved)
CHANGELOG.rstabout the changesAUTHORS.rstOptional:
🔍 Reviewer Checklist
During your review, please check the following:
CHANGELOG.rstupdated accordingly?