Skip to content

feature/validation_integration#1375

Draft
sagemaso wants to merge 138 commits intodevfrom
feature/validation_integration
Draft

feature/validation_integration#1375
sagemaso wants to merge 138 commits intodevfrom
feature/validation_integration

Conversation

@sagemaso
Copy link
Copy Markdown

@sagemaso sagemaso commented Dec 17, 2025

Fixes openego/eGon-validation#10 and openego/eGon-validation#11

🧑‍💻 Contributor Checklist

Before requesting a review, make sure you've completed all of the following:

  • All tests pass locally or via CI
    (for more information on local test, check tox in the Contributing section)
    (CI tests are automatically executed when creating a PR, you can see the results of the checks below)
  • Workflow has run at least once in Test mode
    (optional if no dataset changes are involved)
  • Relevant documentation is updated (API, new features, etc.)
  • Dataset-versions are updated when existing datasets are adjusted.
  • Added a note to CHANGELOG.rst about the changes
  • Added yourself to AUTHORS.rst

Optional:

  • Changes have been tested in Everything mode
  • Extend the checklist for reviewers: Which aspects should be reviewed in particular?

🔍 Reviewer Checklist

During your review, please check the following:

  • Is the code clean, readable, and efficient? Are there any oddities or obvious inefficiencies?
  • Does the code work as expected? (should already be verified by contributor)
  • Do all tests pass? (see CI results)
  • Is the documentation complete and up to date?
  • Is CHANGELOG.rst updated accordingly?
  • Is all necessary metadata complete and correct?
    • If metadata is pending: Is there an appropriate issue filed?

sagemaso and others added 30 commits November 20, 2025 11:53
…into feature/validation_integration

# Conflicts:
#	src/egon/data/datasets/__init__.py
…-integration' into feature/validation-sanity-checks-integration

# Conflicts:
#	src/egon/data/validation/rules/custom/sanity/gas_grid.py
….com:openego/egon-data into feature/validation-sanity-checks-integration
@sagemaso sagemaso requested a review from nesnoj March 4, 2026 11:08
@nesnoj
Copy link
Copy Markdown
Member

nesnoj commented Mar 4, 2026

@sagemaso please make sure you follow the checklists above before converting to "ready for review".

On the failing tox build: as mentioned it is related to #1386 and will be fixed by #1382 but this can take some time.
So I temporarily limited setuptools to <81 in d53a04c and 8bc839c and tox runs successfully.
Before the merge, these commit needs to be reverted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update: implement validation template to datasets

2 participants