networkmanager: only enable the vala bindings if GObject introspection is enabled #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraj
requested changes
Mar 28, 2025
Contributor
kraj
left a comment
kraj
left a comment
There was a problem hiding this comment.
these changes are needed on master branch too so sending patches for master branch first and then requesting a backport to scarthgap would be the right thing to do
Contributor
Author
|
see here: #954 |
The workaround introduced in commit 63db9c0 is no longer needed. Typelib files are now correctly located solely within STAGING_LIBDIR_NATIVE, aligning with the intended build configuration. Removing the workaround avoids the following error during build: cp: cannot stat '.../GObject*typelib': No such file or directory Signed-off: Andreas Fenkart <afenkart@gmail.com>
afenkart
force-pushed
the
networkmanager-scarthgap
branch
2 times, most recently
from
2f2c279 to
716a1a6
Compare
when opting out from the DISTRO_FEATURE gobject-introspection-date, the
build fails with error:
../NetworkManager-1.50.0/meson.build:849:4: ERROR: Assert failed: vala api require GObject introspection. Use -Dvapi=false to disable it
The gobject-introspection-data feature, while ultimately added to
DISTRO_FEATURES via DISTRO_FEATURE_BACKFILL, isn't available during the
vala.bbclass inheritance check. This also excludes derived variables
e.g. GI_DATA_ENABLED.
To properly disable a DISTRO_FEATURE_BACKFILL feature, it must be
included in DISTRO_FEATURE_BACKFILL_CONSIDERED, a variable that is
available during the parsing phase.
Similar situations have been resolved in:
[openembedded-core:31daea70b18b2b2266bf94063b655aaf142a6166]
librsvg: Only enable the Vala bindings if GObject Introspection is enabled
PACKAGECONFIG:append:class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 'vala', '', d)}"
-- and --
[meta-openembedded:d89fc6ffbdf8f947643def51b804052bb5e7ac97
libpeas: add recipe for 2.0.5
PACKAGECONFIG ?= "python3 gjs lua51 ${@bb.utils.contains('DISTRO_FEATURES', 'gobject-introspection', 'vala', '', d)}"
Signed-off: Andreas Fenkart <afenkart@gmail.com>
afenkart
force-pushed
the
networkmanager-scarthgap
branch
from
716a1a6 to
e9852b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build errors in network-manager with GI_DATA_ENABLED = "False"