cherry-pick sox 14.4.2 commits from master to scarthgap-next for CVE fixes #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Add all relevant items from queries: $ sqlite3 nvdcve_2-2.db sqlite> select vendor, product, count(*) from products where product like '%sox%' group by vendor, product; commugen|sox_365|1 libsox_project|libsox|1 sox|sox|3 sox_project|sox|10 sqlite> select vendor, product, count(*) from products where product like '%sound_exchange%' group by vendor, product; sound_exchange_project|sound_exchange|16 Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Last release was done in 2015 but development still continues. Switch to git sources to allow update. Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Resolve many CVEs and other bugs. $ git describe --tags sox-14.4.2-184-gf3094754 $ git log -1 HEAD | grep Date: Date: Thu May 30 14:46:01 2024 +0100 Recipe changes: * removed 0001-Update-exported-symbol-list.patch this commit is included now * refreshed 0001-remove-the-error-line-and-live-without-file-type-det.patch * 0001-tests-Include-math.h-for-fabs-definition.patch affected file was deleted from sources * added autoconf-archive-native dependency for newly used AX_APPEND_COMPILE_FLAGS macro * changed some config options from with/without to enable/disable https://sourceforge.net/p/sox/code/ci/6ff0e9322f9891f5a6ac6c9b3bceffbfca16bec3/ * added +git to PV to indicate version not on hash Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
git log sox-14.4.2..HEAD | grep -o 'CVE-[0-9-]*' | sort -u CVE-2017-11332 CVE-2017-11358 CVE-2017-11359 CVE-2017-15370 CVE-2017-15371 CVE-2017-15372 CVE-2017-15642 CVE-2017-18189 CVE-2019-13590 CVE-2019-8354 CVE-2019-8355 CVE-2019-8356 CVE-2019-8357 Following remaining CVEs are handled in commits: CVE-2019-1010004 - NVD: https://nvd.nist.gov/vuln/detail/CVE-2019-1010004 - report: https://sourceforge.net/p/sox/bugs/299/ - patch: https://sourceforge.net/p/sox/code/ci/09d7388c8ad5701ed9c59d1d600ff6154b066397/ - same commit as CVE-2017-18189 as mentioned in NVD and bugreport texts - https://security-tracker.debian.org/tracker/CVE-2019-1010004 links it - it's only commit in src/xa.c in last 15 years Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use patch from Debian: https://salsa.debian.org/lts-team/packages/sox/-/blob/debian/14.4.2+git20190427-1+deb10u3/debian/patches/CVE-2021-3643.patch Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use patch from Debian: https://salsa.debian.org/lts-team/packages/sox/-/blob/debian/14.4.2+git20190427-1+deb10u3/debian/patches/CVE-2021-23159.patch Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use patch from Debian: https://salsa.debian.org/lts-team/packages/sox/-/blob/debian/14.4.2+git20190427-1+deb10u3/debian/patches/CVE-2021-33844.patch Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use patch from Debian: https://salsa.debian.org/lts-team/packages/sox/-/blob/debian/14.4.2+git20190427-1+deb10u3/debian/patches/CVE-2021-40426.patch Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use patch from Debian: https://salsa.debian.org/lts-team/packages/sox/-/blob/debian/14.4.2+git20190427-1+deb10u3/debian/patches/CVE-2022-31650.patch Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use patch from Debian: https://salsa.debian.org/lts-team/packages/sox/-/blob/debian/14.4.2+git20190427-1+deb10u3/debian/patches/CVE-2022-31651.patch Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Use patch from Debian: https://salsa.debian.org/lts-team/packages/sox/-/blob/debian/14.4.2+git20190427-1+deb10u3/debian/patches/0028-CVE-2023-32627-Filter-null-sampling-rate-in-VOC-code.patch Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Patch for CVE-2021-23159 fixes also this CVE. Stated by: * https://security-tracker.debian.org/tracker/CVE-2023-34432 * https://sourceforge.net/p/sox/bugs/367/ Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Contributor
|
The current Scarthgap version is indeed ancient... do you happen to know if there were any breaking changes (mostly thinking about dropped features or other API incompatibility) between the Scarthgap and Master revisions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sox: Cherry pick the following commits from master to scarthgap-next for CVE patches.
All are related to CVE fixes except
8866910fdd sox: Fix build with GCC-14which is safe to include because it it backward compatible with the scarthgap gcc 13 compiler.