Conversation
The getMissingTemplates call was performed within an if/else but was identical so could be moved up one level higher. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
remote_builder_secrets
branch
from
c32e7eb to
e0b0c1a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Adds support for sealing secrets for use with faas-cli * Tested e2e and saw with a Dockerfile that captured a build time secret - the published image showed the value was captured as expected. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
remote_builder_secrets
branch
from
e0b0c1a to
bce0593
Compare
|
An error occurred while generating the code review file. Please try again. AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remote builder secrets
Motivation and Context
How Has This Been Tested?
time secret - the published image showed the value was captured
as expected.
Types of changes
README/cobra CLI help updated with examples of the new commands.