Add a function to delete files individually #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gounux
approved these changes
Jul 17, 2025
qfieldcloud_sdk/cli.py
Outdated
|
|
||
| _resp = ctx.obj["client"].delete_file(project_id, filename, version_id) | ||
|
|
||
| log(f'Successfully deleted file "{filename}" in project "{project_id}"…') |
Member
There was a problem hiding this comment.
Am not super fan of those … when logging the finish of a successful operation. Personal taste here, feel free to ignore.
Collaborator
Author
There was a problem hiding this comment.
Used quite intensively everywhere else. But in this case it is actually not needed, as it is nothing that takes longer time (processing), I just copy pasted another line in the code. Fixed.
| self, | ||
| project_id: str, | ||
| filename: str, | ||
| version_id: Optional[str], |
Member
There was a problem hiding this comment.
I was about to suggest the version_id: str | None typing, but it seems that the project is python >= 3.8, so better keep it this way.
Collaborator
Author
There was a problem hiding this comment.
Yes, 3.9 is dead by the end of the year, then we upgade to a newer target Python version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know there are
delete_filesbut is a bit annoying that it only accepts glob. Sometimes you need a simple file to be deleted.