fix: do not overwrite with empty file if the server returns HTTP 304 when If-None-Match is sent
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when `If-None-Match` is sent When `If-None-Match` is sent, the server may return HTTP 304 Not Modified with empty response body. This is problematic, as our code was assuming that there is always a file returned by the server if the HTTP status code < 400
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
If-None-Matchis sent, the server may return HTTP 304 Not Modified with empty response body.This is problematic, as our code was assuming that there is always a file returned by the server if the HTTP status code < 400