Avoid double login for 'login' subcommand in CLI #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suricactus
approved these changes
Oct 16, 2025
Collaborator
suricactus
left a comment
suricactus
left a comment
There was a problem hiding this comment.
Nice fix, thank you! I did not test myself, but codewise looks good.
Collaborator
|
Patch release will come in the following week or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
The problem seemed to be that the CLI command
loginattempts a 'pre-login' from the parent CLI command, from the provided flags or env var params.Click then moves onto the
loginsubcommand and runs a login there too - double login.This caused the secondary problem of not respecting the provided positional or flag args for the
logincommand, as prescedence over set environment variables upstream.