Add invalid_tx_code error code to pre-authz code flow#686
Open
Add invalid_tx_code error code to pre-authz code flow#686
Conversation
Contributor
Author
|
@c2bo @tplooker @Sakurann @jogu @paulbastian could somebody please review this. |
paulbastian
approved these changes
Jan 21, 2026
Contributor
paulbastian
left a comment
There was a problem hiding this comment.
This makes a lot of sense, please consider to strengthen the normative language.
Contributor
Author
|
@Sakurann @fkj @paulbastian @tplooker I updated the PR accordingly to:
|
fkj
approved these changes
Feb 19, 2026
Member
fkj
left a comment
There was a problem hiding this comment.
I was convinced during the WG meeting that the transaction code lifetime issue is "superseded" by the pre-authorized code lifetime already being "short-lived", whatever that means for the specific application. So I'm OK with just saying transaction codes SHOULD also be short-lived.
c2bo
approved these changes
Mar 4, 2026
Member
|
In general, LGTM. Assume the following scenario:
Due to one-time usage of tx_code, the Wallet cannot re-issue Access Token if it is expired.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #474