-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8373231: ECDSAOperations::toAffinePoint is redundant #28691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back jjiang! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@johnshajiang The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
myankelev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, this seems to be changing public API, shouldn't it have a csr then?
|
|
||
| /* | ||
| * @test | ||
| * @bug 8189189 8147502 8295010 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the bug id?
It's a class in an internal package ( |
ECDSAOperations::toAffinePointshould be removed, andAffinePoint::fromECPointshould be used instead.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28691/head:pull/28691$ git checkout pull/28691Update a local copy of the PR:
$ git checkout pull/28691$ git pull https://git.openjdk.org/jdk.git pull/28691/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28691View PR using the GUI difftool:
$ git pr show -t 28691Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28691.diff
Using Webrev
Link to Webrev Comment