-
Notifications
You must be signed in to change notification settings - Fork 252
8366221: [11u] TestPromotionFromSurvivorToTenuredAfterMinorGC.java javac build fails #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
|
|
Thanks for the reviews @phohensee Fix the test bug which cause test which cause javac build fails. Change has been verified locally, test-fix only, no risk. |
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/approval request Fix the test bug which cause test which cause javac build fails. Change has been verified locally, test-fix only, no risk. |
|
@sendaoYan |
|
Thnaks for the approved. /integrate |
|
Going to push as commit 716be58.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit 716be58. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
The test gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java use the class SurvivorAlignmentTestMain and AlignmentHelper which located in the same directory with tested class. I think we should build the depencied class explictly to avoid jtreg report javac compile failure.
This test was removed by https://bugs.openjdk.org/browse/JDK-8255298, So this test only effect jdk11u.
Change has been verified locally, test-fix only, no risk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3079/head:pull/3079$ git checkout pull/3079Update a local copy of the PR:
$ git checkout pull/3079$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3079/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3079View PR using the GUI difftool:
$ git pr show -t 3079Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3079.diff
Using Webrev
Link to Webrev Comment