8370489: Some compiler tests miss the @key randomness

[rm-gh-8]

Backporting JDK-8370489: Some compiler tests miss the @key randomness.

This PR adds the missing @key randomness jtreg tag to compiler tests that use randomization via getRandomInstance() to properly categorize them for test execution filtering.

This PR is not clean because the following tests are currently not present in JDK 25

test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java
test/hotspot/jtreg/compiler/igvn/ExpressionFuzzer.java
test/hotspot/jtreg/compiler/loopopts/superword/TestAliasing.java
test/hotspot/jtreg/compiler/vectorapi/VectorMaskCastIdentityTest.java

These tests were not included because it would involve backporting a fairly large commit dependency graph which includes behavioral changes (JDK-8361582, JDK-8359412, JDK-8367531, JDK-8324751 and JDK-8356760)

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST="test/hotspot/jtreg/compiler/arraycopy/stress test/hotspot/jtreg/compiler/intrinsics"

Results attached:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
windows-x64-specific-3-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
macos-aarch64-specific-3-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-x64-specific-3-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-aarch64-specific-3-test.log

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8370489 needs maintainer approval

Issue

• JDK-8370489: Some compiler tests miss the @key randomness (Bug - P5)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/350/head:pull/350
$ git checkout pull/350

Update a local copy of the PR:
$ git checkout pull/350
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 350

View PR using the GUI difftool:
$ git pr show -t 350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/350.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (c45e8e72)

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[rm-gh-8]

/approval request for backport of JDK-8370489: Some compiler tests miss the @key randomness.

This is a test fix.

This PR is not clean because the following tests are currently not present in JDK 25

test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java
test/hotspot/jtreg/compiler/igvn/ExpressionFuzzer.java
test/hotspot/jtreg/compiler/loopopts/superword/TestAliasing.java
test/hotspot/jtreg/compiler/vectorapi/VectorMaskCastIdentityTest.java

These tests were not included because it would involve backporting a fairly large commit dependency graph which includes behavioral changes (JDK-8361582, JDK-8359412, JDK-8367531, JDK-8324751 and JDK-8356760)

For parity with Oracle JDK.

[openjdk]

@rm-gh-8
8370489: The approval request has been created successfully.

[GoeLin]

Hi @rm-gh-8
I think it makes sense to look into backporting below changes as prereq. They are test only and thus bring no risk for the product. But they might be needed by later test backports too, so backporting them as long as it can be done clean might be a good idea. I checked, the first two are clean.
I agree that the other changes should not be backported.

8358772: Template-Framework Library: Primitive Types
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries

[rm-gh-8]

@GoeLin It seems like JDK-8358600 is a test only commit that can be added to make JDK-8367531 cleaner. I'll create dependent CRs following this order:

8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness

I will withdraw this PR once the new version of this PR is created as a dependent PR.

[rm-gh-8]

Withdrawing PR. Replaced by #389