8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces#373
8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces#373rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces. This is a test fix. For parity with Oracle JDK. |
|
/integrate |
|
/sponsor |
|
Going to push as commit e008ce3.
Your commit was automatically rebased without conflicts. |
|
@phohensee @rm-gh-8 Pushed as commit e008ce3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces.
This PR cleans up trailing whitespace in x86-asmtest.py that was introduced in commit openjdk/jdk@916694f and went undetected because jcheck's [checks "whitespace"] config doesn't cover *.py files. The trailing whitespace causes pre-commit hooks to complain during merges, forcing developers to temporarily disable hooks as a workaround.
Ran related tests on linux-x64:
make test TEST="gtest:*AssemblerX86*"Results attached:
linux-x64-specific-test.log
Checked asmtest.out.h file created before and after the commit and they were identical:
asmtest.out.h.old.txt
asmtest.out.h.new.txt
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/373/head:pull/373$ git checkout pull/373Update a local copy of the PR:
$ git checkout pull/373$ git pull https://git.openjdk.org/jdk25u-dev.git pull/373/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 373View PR using the GUI difftool:
$ git pr show -t 373Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/373.diff
Using Webrev
Link to Webrev Comment