Skip to content

8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces#373

Closed
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8344345-V25
Closed

8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces#373
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8344345-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Mar 11, 2026

Backporting JDK-8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces.

This PR cleans up trailing whitespace in x86-asmtest.py that was introduced in commit openjdk/jdk@916694f and went undetected because jcheck's [checks "whitespace"] config doesn't cover *.py files. The trailing whitespace causes pre-commit hooks to complain during merges, forcing developers to temporarily disable hooks as a workaround.

Ran related tests on linux-x64:

make test TEST="gtest:*AssemblerX86*"

Results attached:

linux-x64-specific-test.log

Checked asmtest.out.h file created before and after the commit and they were identical:

asmtest.out.h.old.txt
asmtest.out.h.new.txt


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344345 needs maintainer approval

Issue

  • JDK-8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/373/head:pull/373
$ git checkout pull/373

Update a local copy of the PR:
$ git checkout pull/373
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/373/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 373

View PR using the GUI difftool:
$ git pr show -t 373

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/373.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 078e71f4a3d68d298ab3c383e46d18912e1de7db 8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces Mar 11, 2026
@openjdk
Copy link

openjdk bot commented Mar 11, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 11, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 11, 2026 19:55
@openjdk
Copy link

openjdk bot commented Mar 11, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2026

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Mar 12, 2026

/approval request for backport of JDK-8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces.

This is a test fix.

For parity with Oracle JDK.

@openjdk
Copy link

openjdk bot commented Mar 12, 2026

@rm-gh-8
8344345: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 12, 2026
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Mar 23, 2026

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 23, 2026
@openjdk
Copy link

openjdk bot commented Mar 23, 2026

@rm-gh-8
Your change (at version 81a0d07) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 23, 2026

Going to push as commit e008ce3.
Since your change was applied there have been 53 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2026
@openjdk openjdk bot closed this Mar 23, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 23, 2026
@openjdk
Copy link

openjdk bot commented Mar 23, 2026

@phohensee @rm-gh-8 Pushed as commit e008ce3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants