8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass

[rm-gh-8]

Backporting JDK-8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass.

This PR converts PKCS11 test skip conditions from silent return statements to SkippedException throws, ensuring
skipped tests are properly reported by jtreg rather than appearing as false passes.

This PR is not clean because the return type of initSecmod() was changed to “void” in “SecmodTest.java”, and “FipsModeTLS12.java” needed to be updated to reflect this. This problem was eventually fixed in JDK-8372702, but the backport dependency path to it involves JDK-8368073 and JDK-8368514 (renames FipsModeTLS12.java), which introduce behavioral changes.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/sun/security/pkcs11

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8367096 needs maintainer approval

Issue

• JDK-8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/385/head:pull/385
$ git checkout pull/385

Update a local copy of the PR:
$ git checkout pull/385
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 385

View PR using the GUI difftool:
$ git pr show -t 385

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/385.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• 14d3f56: 8377944: LowMemoryTest2.java#id1 intermittent fails OOME: Metaspace
• b51af16: 8379202: Support linktime-gc on Linux with clang
• d09e1cc: 8376684: Compile OpenJDK in headless mode without required X11 libraries
• ... and 67 more: https://git.openjdk.org/jdk25u-dev/compare/79f0f9ded514c763ad085abb5b156a81bf633c16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (8a3d22db)

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[rm-gh-8]

/approval request for backport of JDK-8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass.

This is a test fix.

This PR is not clean because the return type of initSecmod() was changed to “void” in “SecmodTest.java”, and “FipsModeTLS12.java” needed to be updated to reflect this. This problem was eventually fixed in JDK-8372702, but the backport dependency path to it involves JDK-8368073 and JDK-8368514 (renames FipsModeTLS12.java), which introduce behavioral changes.

For parity with Oracle JDK.

[openjdk]

@rm-gh-8
8367096: The approval request has been created successfully.

[rm-gh-8]

/integrate

[openjdk]

@rm-gh-8
Your change (at version 8a3d22d) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 7b35fc8.
Since your change was applied there have been 73 commits pushed to the master branch:

• 4975b2d: 8370489: Some compiler tests miss the @key randomness
• 9353e89: 8321687: Test vmTestbase/nsk/jvmti/scenarios/contention/TC03/tc03t002/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE
• b164bb0: 8373913: Refactor serialization tests to use JUnit
• ... and 70 more: https://git.openjdk.org/jdk25u-dev/compare/79f0f9ded514c763ad085abb5b156a81bf633c16...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @rm-gh-8 Pushed as commit 7b35fc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.