Skip to content

8361726: Shenandoah: More detailed evacuation instrumentation#391

Closed
earthling-amzn wants to merge 2 commits intoopenjdk:masterfrom
earthling-amzn:backport-8361726-to-25u-dev
Closed

8361726: Shenandoah: More detailed evacuation instrumentation#391
earthling-amzn wants to merge 2 commits intoopenjdk:masterfrom
earthling-amzn:backport-8361726-to-25u-dev

Conversation

@earthling-amzn
Copy link
Copy Markdown

@earthling-amzn earthling-amzn commented Mar 14, 2026

Not clean. Conflicted with 68b27b88b5160dd2883f93928c5f6ce245412495, but not difficult to resolve.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8361726 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8361726: Shenandoah: More detailed evacuation instrumentation (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/391/head:pull/391
$ git checkout pull/391

Update a local copy of the PR:
$ git checkout pull/391
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/391/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 391

View PR using the GUI difftool:
$ git pr show -t 391

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/391.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 14, 2026

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 14, 2026

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361726: Shenandoah: More detailed evacuation instrumentation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport e756c0dbbb7d99df0751d71726b173e4eabcc903 8361726: Shenandoah: More detailed evacuation instrumentation Mar 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 14, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 14, 2026

Webrevs

@openjdk openjdk Bot added the clean Identical backport; no merge resolution required label Mar 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 16, 2026

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@earthling-amzn
Copy link
Copy Markdown
Author

/approval request We would like to backport this feature because it provides valuable information for debugging evacuation related performance issues. We have a follow up backport planned which will make this feature a runtime option in product builds (in this PR, the feature is only available in non-product builds). We (Amazon) have used this feature in production for many months. We have also tested it on several benchmarks and additional jtreg tests beyond what Github runs (jtreg:all with Shenandoah). This change affects nothing outside of Shenandoah.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 18, 2026

@earthling-amzn
8361726: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 18, 2026
@earthling-amzn
Copy link
Copy Markdown
Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 20, 2026

Going to push as commit 7672013.
Since your change was applied there have been 43 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 20, 2026
@openjdk openjdk Bot closed this Mar 20, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 20, 2026

@earthling-amzn Pushed as commit 7672013.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant