8361726: Shenandoah: More detailed evacuation instrumentation#391
8361726: Shenandoah: More detailed evacuation instrumentation#391earthling-amzn wants to merge 2 commits intoopenjdk:masterfrom
Conversation
Reviewed-by: ysr, kdnilsen
|
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
|
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 40 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
|
|
/approval request We would like to backport this feature because it provides valuable information for debugging evacuation related performance issues. We have a follow up backport planned which will make this feature a runtime option in product builds (in this PR, the feature is only available in non-product builds). We (Amazon) have used this feature in production for many months. We have also tested it on several benchmarks and additional jtreg tests beyond what Github runs (jtreg:all with Shenandoah). This change affects nothing outside of Shenandoah. |
|
@earthling-amzn |
|
/integrate |
|
Going to push as commit 7672013.
Your commit was automatically rebased without conflicts. |
|
@earthling-amzn Pushed as commit 7672013. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Not clean. Conflicted with 68b27b88b5160dd2883f93928c5f6ce245412495, but not difficult to resolve.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/391/head:pull/391$ git checkout pull/391Update a local copy of the PR:
$ git checkout pull/391$ git pull https://git.openjdk.org/jdk25u-dev.git pull/391/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 391View PR using the GUI difftool:
$ git pr show -t 391Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/391.diff
Using Webrev
Link to Webrev Comment