Skip to content

8372380: Make hs_err reporting more robust for unattached threads#393

Closed
xiezhaokun wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-xiezhaokun-6e920fbd-master
Closed

8372380: Make hs_err reporting more robust for unattached threads#393
xiezhaokun wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-xiezhaokun-6e920fbd-master

Conversation

@xiezhaokun
Copy link
Copy Markdown
Member

@xiezhaokun xiezhaokun commented Mar 14, 2026

Clean backport of openjdk/jdk@6e920fb


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372380 needs maintainer approval

Issue

  • JDK-8372380: Make hs_err reporting more robust for unattached threads (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/393/head:pull/393
$ git checkout pull/393

Update a local copy of the PR:
$ git checkout pull/393
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 393

View PR using the GUI difftool:
$ git pr show -t 393

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/393.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 14, 2026

👋 Welcome back zxie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 14, 2026

@xiezhaokun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372380: Make hs_err reporting more robust for unattached threads

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport 6e920fbdab17201886804bb53b59188b362f541d 8372380: Make hs_err reporting more robust for unattached threads Mar 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 14, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 14, 2026

⚠️ @xiezhaokun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 14, 2026

Webrevs

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 18, 2026

@xiezhaokun usage: /approval [<id>] (request|cancel) [<text>]

@xiezhaokun
Copy link
Copy Markdown
Member Author

/approval request
I want to backport this enhancement to JDK 25.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 18, 2026

@xiezhaokun
8372380: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Mar 18, 2026
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Mar 18, 2026

Hi @xiezhaokun
The comment in JBS is base for decision whether I approve this: https://bugs.openjdk.org/browse/JDK-8372380
"I want to backport this enhancement to JDK 25." Is just not sufficient.
You need to list Reason, Risk, Testing, Was it clean? Just have a look at other backports ...
Please also read https://wiki.openjdk.org/spaces/JDKUpdates/pages/42598906/How+to+contribute+or+backport+a+fix
Especially Section 6.
I think I have pointed you to that several times now.
You can issue the /approval command again giving a new message text.
I will not point you to this again in future backports, instead I will reject the backport.

The 25u backport here is a good example https://bugs.openjdk.org/browse/JDK-8373120

@openjdk openjdk Bot removed the approval Requires approval; will be removed when approval is received label Mar 18, 2026
@xiezhaokun
Copy link
Copy Markdown
Member Author

/approval request Clean backport 8372380: Make hs_err reporting more robust for unattached threads.
The tier1 test cases all passed. I see no risk for the changes.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 19, 2026

@xiezhaokun
8372380: The approval request has been updated successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 19, 2026
@xiezhaokun
Copy link
Copy Markdown
Member Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 24, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 24, 2026

@xiezhaokun
Your change (at version 3b13d4f) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 24, 2026

Going to push as commit 94657a2.
Since your change was applied there have been 53 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 24, 2026
@openjdk openjdk Bot closed this Mar 24, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2026
@openjdk openjdk Bot removed the sponsor Pull request is ready to be sponsored label Mar 24, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 24, 2026

@shipilev @xiezhaokun Pushed as commit 94657a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants