8377602: Create automated test for PageRange#395
8377602: Create automated test for PageRange#395rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 57 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8377602: Create automated test for PageRange. This is a test fix. For parity with Oracle JDK. |
|
/integrate |
|
/sponsor |
|
Going to push as commit c6590d8.
Your commit was automatically rebased without conflicts. |
|
@phohensee @rm-gh-8 Pushed as commit c6590d8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8377602: Create automated test for PageRange.
This PR adds an automated test (PageRangesAuto.java) for the PageRanges print attribute that was originally written to validate the fix for JDK-8297191, complementing the existing manual test test/jdk/java/awt/print/PrinterJob/PageRanges.java.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/awt/print/PrinterJob/PageRangesAuto.java
macos-aarch64-specific-test.log
linux-x64-specific-test.log
windows-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/395/head:pull/395$ git checkout pull/395Update a local copy of the PR:
$ git checkout pull/395$ git pull https://git.openjdk.org/jdk25u-dev.git pull/395/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 395View PR using the GUI difftool:
$ git pr show -t 395Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/395.diff
Using Webrev
Link to Webrev Comment