You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This backports a fix to JFR path-to-roots-heap-search using DFS that would lead to crashes if object graphs are too deep and we run out of stack. The fix is very simple and low-risk.
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.
openjdkbot
changed the title
Backport 347aae6428358e79a9463b04654f3eaf83450595
8380011: Path-to-gcroots search should not trigger stack overflows
Mar 19, 2026
This backport pull request has now been updated with issue from the original commit.
openjdkbot
added
backport
Port of a pull request already in a different code base
clean
Identical backport; no merge resolution required
labels
Mar 19, 2026
/approval request This fixes a crash in JFR when DFS object graph search gets too deep. Patch is small and low-risk. Tested: GHAs, and ran the contained regression test on Linux x64 manually
⚠️@tstuefe This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvalRequires approval; will be removed when approval is receivedbackportPort of a pull request already in a different code basecleanIdentical backport; no merge resolution requiredrfrPull request is ready for review
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports a fix to JFR path-to-roots-heap-search using DFS that would lead to crashes if object graphs are too deep and we run out of stack. The fix is very simple and low-risk.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/403/head:pull/403$ git checkout pull/403Update a local copy of the PR:
$ git checkout pull/403$ git pull https://git.openjdk.org/jdk25u-dev.git pull/403/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 403View PR using the GUI difftool:
$ git pr show -t 403Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/403.diff
Using Webrev
Link to Webrev Comment