Skip to content

8380011: Path-to-gcroots search should not trigger stack overflows#403

Open
tstuefe wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-tstuefe-347aae64-master
Open

8380011: Path-to-gcroots search should not trigger stack overflows#403
tstuefe wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-tstuefe-347aae64-master

Conversation

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Mar 19, 2026

This backports a fix to JFR path-to-roots-heap-search using DFS that would lead to crashes if object graphs are too deep and we run out of stack. The fix is very simple and low-risk.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8380011 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8380011: Path-to-gcroots search should not trigger stack overflows (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/403/head:pull/403
$ git checkout pull/403

Update a local copy of the PR:
$ git checkout pull/403
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 403

View PR using the GUI difftool:
$ git pr show -t 403

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/403.diff

Using Webrev

Link to Webrev Comment

@tstuefe tstuefe marked this pull request as draft March 19, 2026 14:56
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2026

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 347aae6428358e79a9463b04654f3eaf83450595 8380011: Path-to-gcroots search should not trigger stack overflows Mar 19, 2026
@openjdk
Copy link

openjdk bot commented Mar 19, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 19, 2026
@tstuefe
Copy link
Member Author

tstuefe commented Mar 20, 2026

/approval request This fixes a crash in JFR when DFS object graph search gets too deep. Patch is small and low-risk. Tested: GHAs, and ran the contained regression test on Linux x64 manually

@tstuefe tstuefe marked this pull request as ready for review March 20, 2026 05:59
@openjdk
Copy link

openjdk bot commented Mar 20, 2026

⚠️ @tstuefe This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2026
@openjdk
Copy link

openjdk bot commented Mar 20, 2026

@tstuefe
8380011: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 20, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 20, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant