8376225: [8u] GHA: Apply work-around for missing JNF for MacOSX builds by jerboaa · Pull Request #748 · openjdk/jdk8u-dev

jerboaa · 2026-01-23T18:35:31Z

As the title goes. For newer MacOS X SDKs which have the JavaNativeFoundations framework removed from the SDK, one needs to "install" it manually. In this case we are taking it from the applejdk in GHA. This should help getting MacOSX builds going on the macos-15-intel GHA runners.

The real fix for this is to remove the JNF dependency from the JDK 8u codebase but this effort will take longer and this is an interim measure (noted as such in the comment).

Testing

Tested it on a branch which has MacOSX 15 intel runner support and this patch on top. See here for the GHA run: https://github.com/jerboaa/jdk8u-dev/actions/runs/21296331427 (MacOSX builds succeed)

Thoughts?

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8376225 needs maintainer approval

Issue

JDK-8376225: [8u] GHA: Apply work-around for missing JNF for MacOSX builds (Bug - P4 - Approved)

Reviewers

Andrew John Hughes (@gnu-andrew - Reviewer)

Contributors

Zdenek Zambersky <zzambers@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/748/head:pull/748
$ git checkout pull/748

Update a local copy of the PR:
$ git checkout pull/748
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/748/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 748

View PR using the GUI difftool:
$ git pr show -t 748

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/748.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-01-23T18:36:27Z

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-01-23T18:37:58Z

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8376225: [8u] GHA: Apply work-around for missing JNF for MacOSX builds

Co-authored-by: Zdenek Zambersky <zzambers@openjdk.org>
Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

7d76001: 8376352: [8u] Build failure on Windows 32-bit after JDK-8362308
ffdc8d8: 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on
056cb52: Merge
... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/e3256d666af55ad8a6e33754c7a76eb8743cad88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mlbridge · 2026-01-23T18:41:13Z

Webrevs

01: Full - Incremental (b9886dec)
00: Full (734c805b)

jerboaa · 2026-01-23T18:43:21Z

/help

jerboaa · 2026-01-23T18:44:46Z

/contributor add @zzambers

openjdk · 2026-01-23T18:45:22Z

@jerboaa Available commands:

approval - request for maintainer's approval
approve - null
author - sets an overriding author to be used in the commit when the PR is integrated
backport - create a backport
cc - add or remove an additional classification label
clean - Mark the backport pull request as a clean backport
contributor - adds or removes additional contributors for a PR
covered - used when employer has signed the OCA
csr - require a compatibility and specification request (CSR) for this pull request
help - shows this text
integrate - performs integration of the changes in the PR
issue - edit the list of issues that this PR solves
jep - require a JDK Enhancement Proposal (JEP) for this pull request
keepalive - Re-evaluates the pull request and resets the inactivity timeout.
label - add or remove an additional classification label
open - Set the pull request state to "open"
reviewer - manage additional reviewers for a PR
reviewers - set the number of additional required reviewers for this PR
signed - used after signing the OCA
solves - edit the list of issues that this PR solves
sponsor - performs integration of a PR that is authored by a non-committer
summary - updates the summary in the commit message
test - used to run tests
touch - Re-evaluates the pull request and resets the inactivity timeout.

For additional details, see Pull Request Commands documentation

openjdk · 2026-01-23T18:45:55Z

@jerboaa
Contributor Zdenek Zambersky <zzambers@openjdk.org> successfully added.

gnu-andrew

I'm ok with this as a temporary measure as we discussed on PR#738. I do think we need a specific tracking bug ID rather than reusing 8257852 as there are issues beyond that to resolve. I'll file one now.

gnu-andrew · 2026-01-27T15:55:27Z

I'm ok with this as a temporary measure as we discussed on PR#738. I do think we need a specific tracking bug ID rather than reusing 8257852 as there are issues beyond that to resolve. I'll file one now.

Please use JDK-8376511 as the reference in the text.

jerboaa · 2026-01-27T16:33:35Z

I'm ok with this as a temporary measure as we discussed on PR#738. I do think we need a specific tracking bug ID rather than reusing 8257852 as there are issues beyond that to resolve. I'll file one now.

Please use JDK-8376511 as the reference in the text.

I think I've done that now (on the JBS issue https://bugs.openjdk.org/browse/JDK-8376225).

.github/workflows/submit.yml

gnu-andrew

Thanks.

openjdk · 2026-01-27T19:27:36Z

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

jerboaa · 2026-01-28T12:40:10Z

/approval request Please approve this GHA-only workaround to be able to build on MacOSX 15 which doesn't come with JavaNativeFoundations framework pre-installed which JDK 8 still relies on for the MacOSX build. Low risk since only a CI change. Reviewed by Andrew Hughes. We'll replace it later once we have JNF removed from the code base.

openjdk · 2026-01-28T12:42:10Z

@jerboaa
8376225: The approval request has been created successfully.

gnu-andrew · 2026-01-28T15:36:46Z

/approve yes

openjdk · 2026-01-28T15:39:31Z

@gnu-andrew
8376225: The approval request has been approved.

jerboaa · 2026-01-28T15:45:09Z

/integrate

openjdk · 2026-01-28T15:48:54Z

Going to push as commit 6926a46.
Since your change was applied there have been 13 commits pushed to the master branch:

7d76001: 8376352: [8u] Build failure on Windows 32-bit after JDK-8362308
ffdc8d8: 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on
056cb52: Merge
... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/e3256d666af55ad8a6e33754c7a76eb8743cad88...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-01-28T15:49:06Z

@jerboaa Pushed as commit 6926a46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8376225: [8u] GHA: Apply work-around for missing JNF for MacOSX builds

734c805

openjdk bot added the rfr Pull request is ready for review label Jan 23, 2026

jerboaa mentioned this pull request Jan 23, 2026

8369226: GHA: Switch to MacOS 15 #738

Closed

4 tasks

gnu-andrew suggested changes Jan 27, 2026

View reviewed changes

gnu-andrew reviewed Jan 27, 2026

View reviewed changes

.github/workflows/submit.yml Outdated Show resolved Hide resolved

Use JDK-8376511 over JDK-8257852 in comment

b9886de

gnu-andrew approved these changes Jan 27, 2026

View reviewed changes

openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 28, 2026

openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 28, 2026

openjdk bot added the integrated Pull request has been integrated label Jan 28, 2026

openjdk bot closed this Jan 28, 2026

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 28, 2026

Conversation

jerboaa commented Jan 23, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Contributors

Reviewing

Uh oh!

bridgekeeper bot commented Jan 23, 2026

Uh oh!

openjdk bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

jerboaa commented Jan 23, 2026

Uh oh!

jerboaa commented Jan 23, 2026

Uh oh!

openjdk bot commented Jan 23, 2026

Uh oh!

openjdk bot commented Jan 23, 2026

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

gnu-andrew commented Jan 27, 2026

Uh oh!

jerboaa commented Jan 27, 2026

Uh oh!

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jan 27, 2026

Uh oh!

jerboaa commented Jan 28, 2026

Uh oh!

openjdk bot commented Jan 28, 2026

Uh oh!

gnu-andrew commented Jan 28, 2026

Uh oh!

openjdk bot commented Jan 28, 2026

Uh oh!

jerboaa commented Jan 28, 2026

Uh oh!

openjdk bot commented Jan 28, 2026

Uh oh!

openjdk bot commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

jerboaa commented Jan 23, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Jan 23, 2026 •

edited

Loading

mlbridge bot commented Jan 23, 2026 •

edited

Loading