8369996: Testcase java/net/Socket/B8312065.java fails on Mac, AIX and Solaris#768
8369996: Testcase java/net/Socket/B8312065.java fails on Mac, AIX and Solaris#768yanglong1010 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back lyang! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Pull request overview
Limits execution of the regression test for JDK-8312065 to Linux only, avoiding failures on platforms where the test’s native-library build/run path is currently not portable (e.g., macOS).
Changes:
- Change the jtreg
@requiresconstraint from “non-Windows” to “Linux only” forB8312065.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
@yanglong1010 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
|
|
/approval 8369996 request This patch limits the test for JDK-8312065 to run only on Linux. Maybe in the future somebody with devices steps up to fix the test on macos/aix/solaris. The risk is low. Thanks. |
|
@yanglong1010 |
|
/approve yes |
|
@jerboaa |
|
@yanglong1010 Please integrate. |
Hi,
Could I have a review of this patch ?
This patch limits the test for JDK-8312065 to run only on Linux.
The test for JDK-8312065 needs to build a native library to send signals to Java threads. I don't have Mac, AIX and Solaris devices. Limit the platform is the simplest way for now.
Thanks.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/768/head:pull/768$ git checkout pull/768Update a local copy of the PR:
$ git checkout pull/768$ git pull https://git.openjdk.org/jdk8u-dev.git pull/768/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 768View PR using the GUI difftool:
$ git pr show -t 768Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/768.diff
Using Webrev
Link to Webrev Comment