You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please review this trivial problem listing. We see the test failing in our GHA runs in 8u. Problem list the test until a fix is available so as to reduce test noise.
Thoughts?
Progress
Change must be properly reviewed (1 review required, with at least 1 Reviewer)
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
⚠️@jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request Please approve this problem listing of a CAInterop test which introduced lots of test noise in 8u PR runs. Issue is present in JDK head too, but since it's a manual test there not being run as frequently as in 8u. Test change only, low risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvalRequires approval; will be removed when approval is receivedrfrPull request is ready for review
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this trivial problem listing. We see the test failing in our GHA runs in 8u. Problem list the test until a fix is available so as to reduce test noise.
Thoughts?
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/775/head:pull/775$ git checkout pull/775Update a local copy of the PR:
$ git checkout pull/775$ git pull https://git.openjdk.org/jdk8u-dev.git pull/775/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 775View PR using the GUI difftool:
$ git pr show -t 775Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/775.diff
Using Webrev
Link to Webrev Comment