Skip to content

8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data#777

Open
mrserb wants to merge 2 commits intoopenjdk:masterfrom
mrserb:JDK-8369032
Open

8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data#777
mrserb wants to merge 2 commits intoopenjdk:masterfrom
mrserb:JDK-8369032

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Mar 21, 2026

Hi all,

This pull request contains a backport of commit ed153ee2 from the openjdk/jdk repository.

The backport is mostly clean: I have to update the test to use explicit types in SerializedFormSize instead of var.

The commit being backported was authored by Sergey Bylokhov on 21 Oct 2025 and was reviewed by Harshitha Onkar.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369032 needs maintainer approval

Issue

  • JDK-8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/777/head:pull/777
$ git checkout pull/777

Update a local copy of the PR:
$ git checkout pull/777
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 777

View PR using the GUI difftool:
$ git pr show -t 777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/777.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2026

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 21, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ed153ee2c4614c814da92c23c4741eed68ce1a0c 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data Mar 21, 2026
@openjdk
Copy link

openjdk bot commented Mar 21, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Mar 21, 2026
@mrserb mrserb marked this pull request as ready for review March 21, 2026 23:08
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 21, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant