Conversation
|
👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
| PREVIEW_PATH := META-INF/preview | ||
|
|
||
| ifneq ($(COMPILER), bootjdk) | ||
| MODULE_VALUECLASS_SRC_DIRS := $(call FindModuleValueClassSrcDirs, $(MODULE)) |
There was a problem hiding this comment.
Lots of this is unrelated to annotation processing per se, just renaming "value class" stuff when it's really just "preview" stuff more generally.
make/CompileJavaModules.gmk
Outdated
| --system none \ | ||
| --enable-preview -source $(JDK_SOURCE_TARGET_VERSION), \ | ||
| --enable-preview -source $(JDK_SOURCE_TARGET_VERSION) \ | ||
| -processor build.tools.valueclasses.GenValueClassList, \ |
There was a problem hiding this comment.
Just this 1 line triggers the new (unwanted) warnings.
There was a problem hiding this comment.
Adding -Xlint:-removal \ on the line above this make compilation work.
| # source root, which are not being recompiled in this compilation: | ||
| $1_AUGMENTED_CLASSPATH += $$(BUILDTOOLS_OUTPUTDIR)/depend $$($1_BIN) | ||
| $1_AUGMENTED_CLASSPATH += $$($1_BIN) | ||
| $1_PROCESSOR_PATH += $$(BUILDTOOLS_OUTPUTDIR)/depend |
There was a problem hiding this comment.
Seems to work if the /depend dir is no longer also in the augmented classpath.
I don't think order matters here (the user path is first).
make/CompileJavaModules.gmk
Outdated
| EXCLUDE_FILES := $(EXCLUDE_FILES) \ | ||
| KEEP_ALL_TRANSLATIONS := $(KEEP_ALL_TRANSLATIONS), \ | ||
| DEPENDS := $($(MODULE)), \ | ||
| PROCESSOR_PATH := $(BUILDTOOLS_OUTPUTDIR)/jdk_tools_classes, \ |
There was a problem hiding this comment.
New argument to add to the default path containing /depend dir.
1 participant
Progress
Error
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2164/head:pull/2164$ git checkout pull/2164Update a local copy of the PR:
$ git checkout pull/2164$ git pull https://git.openjdk.org/valhalla.git pull/2164/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2164View PR using the GUI difftool:
$ git pr show -t 2164Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2164.diff