8380197: [REDO] [lworld] OptimizePtrCompare is too conservative

[rwestrel]

BCEscapeAnalyzer can conservatively mark all arguments as being returned by a method. When that happens, it includes arguments that are not the same as the return type. That's an issue for flattened values because they then don't have the same fields. The way I dealt with that corner case in my previous patch was broken because it didn't handle cases where in all the arguments, some have the same type as the return type, some not.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8380197: [REDO] [lworld] OptimizePtrCompare is too conservative (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2239/head:pull/2239
$ git checkout pull/2239

Update a local copy of the PR:
$ git checkout pull/2239
$ git pull https://git.openjdk.org/valhalla.git pull/2239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2239

View PR using the GUI difftool:
$ git pr show -t 2239

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2239.diff

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@rwestrel Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@rwestrel Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.