Feature/archie test#4258
Draft
tothandras wants to merge 10 commits into
Draft
Conversation
…e.json Older Archie (pre-2.4.4) was persisting the absolute project path into .archie/deep_scan_state.json under run_context.project_root, which leaked "/Users/hamutarto/DEV/gbr/openmeter" into the committed state file. Archie 2.4.4 stopped writing this field (BitRaptors/Archie#55). The existing leaked value is removed here so the committable state stays machine-agnostic and portable across dev laptops / CI runners. No other paths leaked — verified with grep for /Users/, /home/, /root/, /var/folders/, and "gbr" across .archie/, CLAUDE.md, AGENTS.md, .claude/. Every remaining "/" string comes from actual gitignore content or doc examples, not from environment-specific paths.
… rename - Replace time.Now() with clock.Now() in adapter/manage.go DeleteMeter - Make OrderBy switch in adapter/meter.go return a typed validation error for unknown values instead of silently falling back to createdAt - Rename package declaration in all httphandler/*.go files from httpdriver to httphandler so directory name matches package name Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ngRepo ListMeters and GetMeterByIDOrSlug now rebind to any ctx-carried Ent transaction, matching the pattern used by all mutating adapter methods. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Meter] Replace the ad-hoc []PreUpdateMeterHook slice in ManageService with the canonical models.ServiceHookRegistry[Meter] pattern used by customer, subscription, and entitlement. The new RegisterHooks method aligns ManageService with the ServiceHooks interface. Pre-update hook now receives *Meter (the current entity) rather than UpdateMeterInput, matching the ServiceHook[T].PreUpdate signature. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…+1s hack Use clock.Now() in both ListEventsParams.Validate() and the default From floor in the v1 ListEvents handler so tests can freeze time. Remove the +1s workaround that compensated for the two separate time.Now() calls drifting apart — clock.Now() is the same instant across both call sites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #(issue)
Notes for reviewer