Open
Conversation
Author
|
Hi @fkiraly Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
This PR implements time-based cache invalidation for dataset descriptions in
_get_dataset_description.Currently, the dataset description (
description.xml) is cached indefinitely once downloaded. However, dataset metadata such as status (e.g., active or deactivated) can change on the server. Because the cache never expires, users may receive outdated dataset metadata if the local cache becomes stale.This change introduces a simple TTL (time-to-live) mechanism for the cached description file:
DESCRIPTION_CACHE_TTLis introduced (24 hours)._get_dataset_descriptionis called, the modification time of the cacheddescription.xmlfile is checked.This ensures that cached dataset descriptions are periodically refreshed while still preserving the existing caching behavior and minimizing additional API calls.
The change addresses the existing TODO in the code suggesting that the cache should invalidate itself after some time.