This repository was archived by the owner on Nov 13, 2023. It is now read-only.
Escapes FV_JVM_ARGS in flowvisor.sh#270
Open
pedroarthur wants to merge 1 commit intoopennetworkinglab:masterfrom
Open
Escapes FV_JVM_ARGS in flowvisor.sh#270pedroarthur wants to merge 1 commit intoopennetworkinglab:masterfrom
pedroarthur wants to merge 1 commit intoopennetworkinglab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it is used in a '-z' shell's test, FV_JVM_ARGS needs to be escaped. Otherwise, if you try to pass many options, "-server -Xmx2G", for example, bash will return "[: too many arguments".