Add multi-cloud support, Azure Key Vault, ECR pull secrets, and analytics Redis SSL#29
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Azure Key Vault as an External Secrets Operator backend option for this Helm chart, allowing secrets to be synced from either AWS Secrets Manager (existing behavior) or Azure Key Vault (new behavior) based on a values flag.
Changes:
- Added
externalSecrets.providerandexternalSecrets.azureKeyVault.vaultUrlvalues to configure Azure Key Vault usage. - Updated the
SecretStoreandExternalSecrettemplates to switch between AWS Secrets Manager and Azure Key Vault based on the selected provider. - Added optional
externalSecrets.serviceAccount.labelssupport when the chart creates the external-secrets ServiceAccount.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| chart/values.yaml | Introduces provider selection and Azure Key Vault configuration values for external secrets. |
| chart/templates/external-secret.yaml | Implements provider-based rendering of SecretStore/ExternalSecret and supports SA labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+50
to
+64
| {{- if .Values.global.containerSecurityContext.enabled }} | ||
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
| readOnlyRootFilesystem: false | ||
| runAsNonRoot: false | ||
| runAsUser: 0 | ||
| capabilities: | ||
| drop: | ||
| - ALL | ||
| add: | ||
| - NET_BIND_SERVICE | ||
| - CHOWN | ||
| - SETGID | ||
| - SETUID | ||
| {{- end }} |
- Add required validation for vaultUrl/tenantId when azure-keyvault provider - Add fail for unsupported externalSecrets.provider values - Extract $provider variable to reduce duplication in external-secret.yaml - Restrict ECR cronjob RBAC to specific secret resourceNames - Pin kubectl version to v1.32.3 in ECR cronjob - Fix appSecretName fallback when empty (use secretName instead) - Update renderEnv comment to document skipDuplicateSecrets param - Fix analytics configOverride whitespace (avoid left-trim concatenation) - Fix values.yaml comment for ECR secret key names (AWS_ACCESS_KEY_ID) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MarceloRGonc
changed the title
…tics configOverride Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MarceloRGonc
changed the title
Comment on lines
+50
to
+64
| {{- if .Values.global.containerSecurityContext.enabled }} | ||
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
| readOnlyRootFilesystem: false | ||
| runAsNonRoot: false | ||
| runAsUser: 0 | ||
| capabilities: | ||
| drop: | ||
| - ALL | ||
| add: | ||
| - NET_BIND_SERVICE | ||
| - CHOWN | ||
| - SETGID | ||
| - SETUID | ||
| {{- end }} |
Comment on lines
+19
to
+25
| - apiGroups: [""] | ||
| resources: ["secrets"] | ||
| resourceNames: [{{ .Values.ecrCredentialRefresh.imagePullSecretName | default "ecr-pull-secret" | quote }}] | ||
| verbs: ["get", "patch", "delete"] | ||
| - apiGroups: [""] | ||
| resources: ["secrets"] | ||
| verbs: ["create"] |
…ent secret refresh - README: fix imagePullSecrets example to use string list (not objects) - deployment-analytics: add checksum/analytics-config annotation for rollout on configOverride changes - cronjob-ecr-credential-refresh: require registry when enabled via Helm required() - cronjob-ecr-credential-refresh: use dry-run + apply instead of delete + create to avoid secret gap Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…efresh Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| --from-literal=AWS_SECRET_ACCESS_KEY=<YOUR_ECR_SECRET_ACCESS_KEY> | ||
| ``` | ||
|
|
||
| The IAM user needs only `ecr:GetAuthorizationToken`, `ecr:BatchGetImage`, and `ecr:GetDownloadUrlForLayer` permissions. |
|
|
||
| **External Secrets Operator (manual):** | ||
| ```yaml | ||
| apiVersion: external-secrets.io/v1beta1 |
Comment on lines
+51
to
+63
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
| readOnlyRootFilesystem: false | ||
| runAsNonRoot: false | ||
| runAsUser: 0 | ||
| capabilities: | ||
| drop: | ||
| - ALL | ||
| add: | ||
| - NET_BIND_SERVICE | ||
| - CHOWN | ||
| - SETGID | ||
| - SETUID |
Comment on lines
+88
to
+99
| KUBECTL_VERSION="v1.32.3" | ||
| KUBECTL_SHA256="ab209d0c5134b61486a0486585604a616a5bb2fc07df46d304b3c95817b2d79f" | ||
| curl -sLO "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/amd64/kubectl" | ||
| echo "${KUBECTL_SHA256} kubectl" | sha256sum -c - | ||
| chmod +x kubectl && mv kubectl /usr/local/bin/ | ||
| TOKEN=$(aws ecr get-login-password --region "$AWS_REGION") | ||
| kubectl create secret docker-registry "$SECRET_NAME" \ | ||
| -n "$NAMESPACE" \ | ||
| --docker-server="$ECR_REGISTRY" \ | ||
| --docker-username=AWS \ | ||
| --docker-password="$TOKEN" \ | ||
| --dry-run=client -o yaml | kubectl apply -f - |
Comment on lines
+83
to
+100
| command: | ||
| - /bin/bash | ||
| - -c | ||
| - | | ||
| set -euo pipefail | ||
| KUBECTL_VERSION="v1.32.3" | ||
| KUBECTL_SHA256="ab209d0c5134b61486a0486585604a616a5bb2fc07df46d304b3c95817b2d79f" | ||
| curl -sLO "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/amd64/kubectl" | ||
| echo "${KUBECTL_SHA256} kubectl" | sha256sum -c - | ||
| chmod +x kubectl && mv kubectl /usr/local/bin/ | ||
| TOKEN=$(aws ecr get-login-password --region "$AWS_REGION") | ||
| kubectl create secret docker-registry "$SECRET_NAME" \ | ||
| -n "$NAMESPACE" \ | ||
| --docker-server="$ECR_REGISTRY" \ | ||
| --docker-username=AWS \ | ||
| --docker-password="$TOKEN" \ | ||
| --dry-run=client -o yaml | kubectl apply -f - | ||
| echo "✅ ECR pull secret refreshed successfully" |
maor-rozenfeld
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-4265