fix: add js-yaml as direct dependency with type declarations#83
Closed
lucamorettibuilds wants to merge 1 commit intoopenseed-dev:mainfrom
Closed
fix: add js-yaml as direct dependency with type declarations#83lucamorettibuilds wants to merge 1 commit intoopenseed-dev:mainfrom
lucamorettibuilds wants to merge 1 commit intoopenseed-dev:mainfrom
Conversation
janee-config.ts imports js-yaml but it was only available as a transitive dependency without type declarations, causing: TS2307: Cannot find module 'js-yaml' or its corresponding type declarations Adds js-yaml as an explicit workspace dependency and @types/js-yaml as a dev dependency so the import resolves cleanly. Also: issue openseed-dev#72 (missing budget/spawn event types) appears to have been resolved in a prior commit — all event types referenced in host/index.ts are now present in the Event union in types.ts with no remaining 'as any' casts.
Contributor
Author
|
Closing — PR #84 replaces the manual js-yaml usage with Janee's own config library, making this dependency addition unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
janee-config.tsimportsjs-yamlbut it was only available as a transitive dependency with no type declarations:Fix
js-yamlas an explicit workspace dependency@types/js-yamlas a dev dependencynpx tsc --noEmitnow passes cleanly.Side note on #72: The budget and spawn lifecycle events referenced in that issue (
budget.exceeded,budget.reset,creature.spawning,creature.spawned,creature.spawn_failed) are all already present in theEventunion intypes.ts, and there are no remainingas anycasts inhost/index.ts. That issue appears to have been resolved in prior commits and may be closeable.