Skip to content

HYPERFLEET-1097 - docs: update vendor label to "Red Hat, Inc."#140

Open
ciaranRoche wants to merge 1 commit into
mainfrom
HYPERFLEET-1097-fix-vendor-label
Open

HYPERFLEET-1097 - docs: update vendor label to "Red Hat, Inc."#140
ciaranRoche wants to merge 1 commit into
mainfrom
HYPERFLEET-1097-fix-vendor-label

Conversation

@ciaranRoche
Copy link
Copy Markdown
Contributor

Summary

  • Update container image standard and Dockerfile template to use vendor="Red Hat, Inc." instead of "Red Hat"
  • EC labels.required_labels requires the full legal entity name

Test plan

  • Standards audit passes after merge

🤖 Generated with Claude Code

EC requires vendor="Red Hat, Inc." not "Red Hat". Update the
container image standard and Dockerfile template to match.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from Mischulee and ma-hill May 15, 2026 15:31
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mbrudnoy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated container image standard documentation with standardized vendor label values for improved consistency across container images.

Walkthrough

The PR updates the container image standard documentation to standardize the vendor OCI label value across three locations. The vendor label is changed from Red Hat to Red Hat, Inc. in the Dockerfile LABEL example under the Container Labels section, in the Required Labels reference table, and in the reference Dockerfile snippet. This ensures consistent standardization of the vendor label value throughout the documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the vendor label value from 'Red Hat' to 'Red Hat, Inc.' in the container image standard documentation.
Description check ✅ Passed The description is directly related to the changeset, explaining both the update and its rationale (EC labels requirement for full legal entity name), and includes a test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1097-fix-vendor-label

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@hyperfleet/standards/container-image-standard.md`:
- Around line 231-235: The standard shows the image metadata label `vendor`
should be the full organization string (e.g., `Red Hat, Inc.`) but three service
repositories still use `vendor="Red Hat"`; create and track follow-up PRs in the
repositories openshift-hyperfleet/hyperfleet-api,
openshift-hyperfleet/hyperfleet-sentinel, and
openshift-hyperfleet/hyperfleet-adapter to update their Dockerfiles/metadata to
use the exact `vendor` label value `Red Hat, Inc.`, ensure the `name` and
`version` labels remain unchanged, and add a short PR description referencing
the container image standard so this change is traced for EC compliance.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 009d2fc8-d2cd-4cd7-a7a6-1675be6b8605

📥 Commits

Reviewing files that changed from the base of the PR and between f1ac5a4 and 51b5a98.

📒 Files selected for processing (1)
  • hyperfleet/standards/container-image-standard.md

Comment thread hyperfleet/standards/container-image-standard.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant