-
Notifications
You must be signed in to change notification settings - Fork 74
[release-1.37] set soft ulimit -n to the value of the hard limit for envoy #3945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.37] set soft ulimit -n to the value of the hard limit for envoy #3945
Conversation
|
/test ? |
|
@maschmid: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test 421-operator-e2e |
|
/test 421-operator-e2e |
dsimansk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, Kaustubh-pande, maschmid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'll ignore the "generated files" on this one if you don't mind. |
|
actually, we probably need to fix this in net-kourier? |
34f08db
into
openshift-knative:release-1.37
|
(openshift-knative/net-kourier#406 merged) |
Fixes JIRA #SRVKS-1343
Proposed Changes
(this is only needed for our envoy, as e.g. golang does that automatically since https://go-review.googlesource.com/c/go/+/393354/4/src/os/rlimit.go#27 ) , and so do Java-based images (when
-XX:+MaxFDLimitis used by default)