Skip to content

AGENT-1193: Add mirror-path and registry-cert support for OVE ISO builds #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rwsu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AGENT-1193: Add mirror-path and registry-cert support for OVE ISO builds #1830

rwsu wants to merge 1 commit into from

Conversation

@rwsu
Copy link
Contributor

@rwsu rwsu commented Dec 19, 2025 •
edited
Loading

Add support for using pre-mirrored images and custom registry certificates when building OVE ISOs, enabling disconnected deployments with custom registries.

Changes for mirror-path:

  • Pass --mirror-path to build-ove-image.sh when MIRROR_IMAGES is enabled
  • Appliance skips oc-mirror and uses pre-mirrored images when --mirror-path is provided

Changes for registry-cert:

  • Add --registry-cert parameter for custom registry TLS certificates
  • Support both script build method (faster for development/debugging) and container build method
  • Use unified mechanism across both build methods
  • Convert to REGISTRY_CERT make variable for containerized builds

Assisted-by: Claude Sonnet 4.5 noreply@anthropic.com

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2025
@openshift-ci openshift-ci bot requested review from celebdor and zaneb December 19, 2025 23:42
@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mkowalski for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rwsu rwsu changed the title WIP: Add support for passing pre-mirrored images to appliance AGENT-1193: Add mirror-path and registry-cert support for OVE ISO builds Jan 13, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@rwsu
Copy link
Contributor Author

rwsu commented Jan 13, 2026

/cc @andfasano @bfournie @pawanpinjarkar
/uncc @celebdor

@openshift-ci openshift-ci bot requested review from andfasano, bfournie and pawanpinjarkar and removed request for celebdor January 13, 2026 23:03
@rwsu rwsu force-pushed the AGENT-1193-v3 branch 2 times, most recently from e004cad to deee8cc Compare January 15, 2026 19:36
@rwsu
AGENT-1193: Add mirror-path and registry-cert support for OVE ISO builds
10b8460 
Add support for using pre-mirrored images (--mirror-path) and custom
registry certificates (--registry-cert) when building OVE ISOs. This
allows building ISOs in disconnected environments without requiring
oc-mirror to run during the build process.

Note: mirror-path and registry-cert options are only available when
using the script build method (AGENT_ISO_NO_REGISTRY_BUILD_METHOD=script).
The container build method does not support these options.

Changes:
- Refactor create_agent_iso_no_registry() for better readability
- Extract helper functions into agent/iso_no_registry.sh
- Add mirror-path and registry-cert support to script build method
- Pass mirror-path to skip oc-mirror execution in appliance
- Pass registry certificate for custom registries with self-signed certs

Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2026 •
edited
Loading

@rwsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-serial-ipv4-1of2 deee8cc link true /test e2e-metal-ipi-serial-ipv4-1of2
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 10b8460 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-bm-bond 10b8460 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-agent-ha-dualstack 10b8460 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 10b8460 link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaneb zaneb Awaiting requested review from zaneb

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rwsu